From 6419bb529b93814c1078850de9ba6d9c91f2f6b0 Mon Sep 17 00:00:00 2001
From: Yuri Pankov <yuripv@FreeBSD.org>
Date: Sat, 13 Jun 2020 08:37:24 +0000
Subject: [PATCH] locale: exit 1 if unknown keyword was specified

PR:		241906
Submitted by:	Akos Somfai <akos.somfai@gmail.com>
---
 usr.bin/locale/locale.c             | 16 ++++++++--------
 usr.bin/locale/tests/locale_test.sh | 16 ++++++++++++++++
 2 files changed, 24 insertions(+), 8 deletions(-)

diff --git a/usr.bin/locale/locale.c b/usr.bin/locale/locale.c
index 022c05358703..052caa64cff9 100644
--- a/usr.bin/locale/locale.c
+++ b/usr.bin/locale/locale.c
@@ -61,7 +61,7 @@ void	list_locales(void);
 const char *lookup_localecat(int);
 char	*kwval_lconv(int);
 int	kwval_lookup(const char *, char **, int *, int *, int *);
-void	showdetails(const char *);
+int	showdetails(const char *);
 void	showkeywordslist(char *substring);
 void	showlocale(void);
 void	usage(void);
@@ -414,7 +414,8 @@ main(int argc, char *argv[])
 			setlocale(LC_ALL, "");
 		if (argc > 0) {
 			while (argc > 0) {
-				showdetails(*argv);
+				if (showdetails(*argv) != 0)
+					exit(EXIT_FAILURE);
 				argv++;
 				argc--;
 			}
@@ -837,19 +838,16 @@ kwval_lookup(const char *kwname, char **kwval, int *cat, int *type, int *alloc)
  * Show details about requested keyword according to '-k' and/or '-c'
  * command line options specified.
  */
-void
+int
 showdetails(const char *kw)
 {
 	int	type, cat, tmpval, alloc;
 	char	*kwval;
 
 	if (kwval_lookup(kw, &kwval, &cat, &type, &alloc) == 0) {
-		/*
-		 * invalid keyword specified.
-		 * XXX: any actions?
-		 */
+		/* Invalid keyword specified */
 		fprintf(stderr, "Unknown keyword: `%s'\n", kw);
-		return;
+		return (1);
 	}
 
 	if (prt_categories) {
@@ -889,6 +887,8 @@ showdetails(const char *kw)
 
 	if (alloc)
 		free(kwval);
+
+	return (0);
 }
 
 /*
diff --git a/usr.bin/locale/tests/locale_test.sh b/usr.bin/locale/tests/locale_test.sh
index e67e641916b4..aa6f870c3750 100755
--- a/usr.bin/locale/tests/locale_test.sh
+++ b/usr.bin/locale/tests/locale_test.sh
@@ -160,8 +160,24 @@ no_flags_posix_body()
 	    noexpr
 }
 
+atf_test_case k_flag_unknown_kw
+k_flag_unknown_kw_head()
+{
+	atf_set "descr" \
+	    "Verify 'locale -k' exit status is '1' for unknown keywords"
+}
+k_flag_unknown_kw_body()
+{
+	export LC_ALL="C"
+
+	# Hopefully the keyword will stay nonexistent
+	atf_check -s exit:1 -o empty -e ignore locale -k nonexistent
+}
+
+
 atf_init_test_cases()
 {
 	atf_add_test_case k_flag_posix
 	atf_add_test_case no_flags_posix
+	atf_add_test_case k_flag_unknown_kw
 }