Correct a real brain-o in my check for when a "fixup" should be run.

Don't recreate parent menus just for submenus - it's irritating.
This commit is contained in:
jkh 1997-01-19 10:27:12 +00:00
parent 1d0095968b
commit 64f19380c2
6 changed files with 15 additions and 15 deletions

View File

@ -52,7 +52,7 @@ int
dmenuSubmenu(dialogMenuItem *tmp)
{
return (dmenuOpenSimple((DMenu *)(tmp->data), FALSE) ? DITEM_SUCCESS : DITEM_FAILURE) |
DITEM_RECREATE;
DITEM_RESTORE;
}
int

View File

@ -716,10 +716,10 @@ installCommit(dialogMenuItem *self)
need_bin = Dists & DIST_BIN;
i = distExtractAll(self);
if (DITEM_STATUS(i) == DITEM_SUCCESS && (!need_bin || !(Dists & DIST_BIN)))
i = installFixup(self);
else
i = DITEM_FAILURE;
if (DITEM_STATUS(i) == DITEM_SUCCESS) {
if (need_bin && !(Dists & DIST_BIN))
i = installFixup(self);
}
variable_set2(SYSTEM_STATE, DITEM_STATUS(i) == DITEM_FAILURE ? "error-install" : "full-install");
return i | DITEM_RESTORE;
}

View File

@ -52,7 +52,7 @@ int
dmenuSubmenu(dialogMenuItem *tmp)
{
return (dmenuOpenSimple((DMenu *)(tmp->data), FALSE) ? DITEM_SUCCESS : DITEM_FAILURE) |
DITEM_RECREATE;
DITEM_RESTORE;
}
int

View File

@ -716,10 +716,10 @@ installCommit(dialogMenuItem *self)
need_bin = Dists & DIST_BIN;
i = distExtractAll(self);
if (DITEM_STATUS(i) == DITEM_SUCCESS && (!need_bin || !(Dists & DIST_BIN)))
i = installFixup(self);
else
i = DITEM_FAILURE;
if (DITEM_STATUS(i) == DITEM_SUCCESS) {
if (need_bin && !(Dists & DIST_BIN))
i = installFixup(self);
}
variable_set2(SYSTEM_STATE, DITEM_STATUS(i) == DITEM_FAILURE ? "error-install" : "full-install");
return i | DITEM_RESTORE;
}

View File

@ -52,7 +52,7 @@ int
dmenuSubmenu(dialogMenuItem *tmp)
{
return (dmenuOpenSimple((DMenu *)(tmp->data), FALSE) ? DITEM_SUCCESS : DITEM_FAILURE) |
DITEM_RECREATE;
DITEM_RESTORE;
}
int

View File

@ -716,10 +716,10 @@ installCommit(dialogMenuItem *self)
need_bin = Dists & DIST_BIN;
i = distExtractAll(self);
if (DITEM_STATUS(i) == DITEM_SUCCESS && (!need_bin || !(Dists & DIST_BIN)))
i = installFixup(self);
else
i = DITEM_FAILURE;
if (DITEM_STATUS(i) == DITEM_SUCCESS) {
if (need_bin && !(Dists & DIST_BIN))
i = installFixup(self);
}
variable_set2(SYSTEM_STATE, DITEM_STATUS(i) == DITEM_FAILURE ? "error-install" : "full-install");
return i | DITEM_RESTORE;
}