Correct a real brain-o in my check for when a "fixup" should be run.
Don't recreate parent menus just for submenus - it's irritating.
This commit is contained in:
parent
1d0095968b
commit
64f19380c2
@ -52,7 +52,7 @@ int
|
||||
dmenuSubmenu(dialogMenuItem *tmp)
|
||||
{
|
||||
return (dmenuOpenSimple((DMenu *)(tmp->data), FALSE) ? DITEM_SUCCESS : DITEM_FAILURE) |
|
||||
DITEM_RECREATE;
|
||||
DITEM_RESTORE;
|
||||
}
|
||||
|
||||
int
|
||||
|
@ -716,10 +716,10 @@ installCommit(dialogMenuItem *self)
|
||||
|
||||
need_bin = Dists & DIST_BIN;
|
||||
i = distExtractAll(self);
|
||||
if (DITEM_STATUS(i) == DITEM_SUCCESS && (!need_bin || !(Dists & DIST_BIN)))
|
||||
i = installFixup(self);
|
||||
else
|
||||
i = DITEM_FAILURE;
|
||||
if (DITEM_STATUS(i) == DITEM_SUCCESS) {
|
||||
if (need_bin && !(Dists & DIST_BIN))
|
||||
i = installFixup(self);
|
||||
}
|
||||
variable_set2(SYSTEM_STATE, DITEM_STATUS(i) == DITEM_FAILURE ? "error-install" : "full-install");
|
||||
return i | DITEM_RESTORE;
|
||||
}
|
||||
|
@ -52,7 +52,7 @@ int
|
||||
dmenuSubmenu(dialogMenuItem *tmp)
|
||||
{
|
||||
return (dmenuOpenSimple((DMenu *)(tmp->data), FALSE) ? DITEM_SUCCESS : DITEM_FAILURE) |
|
||||
DITEM_RECREATE;
|
||||
DITEM_RESTORE;
|
||||
}
|
||||
|
||||
int
|
||||
|
@ -716,10 +716,10 @@ installCommit(dialogMenuItem *self)
|
||||
|
||||
need_bin = Dists & DIST_BIN;
|
||||
i = distExtractAll(self);
|
||||
if (DITEM_STATUS(i) == DITEM_SUCCESS && (!need_bin || !(Dists & DIST_BIN)))
|
||||
i = installFixup(self);
|
||||
else
|
||||
i = DITEM_FAILURE;
|
||||
if (DITEM_STATUS(i) == DITEM_SUCCESS) {
|
||||
if (need_bin && !(Dists & DIST_BIN))
|
||||
i = installFixup(self);
|
||||
}
|
||||
variable_set2(SYSTEM_STATE, DITEM_STATUS(i) == DITEM_FAILURE ? "error-install" : "full-install");
|
||||
return i | DITEM_RESTORE;
|
||||
}
|
||||
|
@ -52,7 +52,7 @@ int
|
||||
dmenuSubmenu(dialogMenuItem *tmp)
|
||||
{
|
||||
return (dmenuOpenSimple((DMenu *)(tmp->data), FALSE) ? DITEM_SUCCESS : DITEM_FAILURE) |
|
||||
DITEM_RECREATE;
|
||||
DITEM_RESTORE;
|
||||
}
|
||||
|
||||
int
|
||||
|
@ -716,10 +716,10 @@ installCommit(dialogMenuItem *self)
|
||||
|
||||
need_bin = Dists & DIST_BIN;
|
||||
i = distExtractAll(self);
|
||||
if (DITEM_STATUS(i) == DITEM_SUCCESS && (!need_bin || !(Dists & DIST_BIN)))
|
||||
i = installFixup(self);
|
||||
else
|
||||
i = DITEM_FAILURE;
|
||||
if (DITEM_STATUS(i) == DITEM_SUCCESS) {
|
||||
if (need_bin && !(Dists & DIST_BIN))
|
||||
i = installFixup(self);
|
||||
}
|
||||
variable_set2(SYSTEM_STATE, DITEM_STATUS(i) == DITEM_FAILURE ? "error-install" : "full-install");
|
||||
return i | DITEM_RESTORE;
|
||||
}
|
||||
|
Loading…
Reference in New Issue
Block a user