d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix for boot issue: Don't disable BARs on AGP devices. In general:

Browse Source 
Don't disable BARs on any PCI display devices, because doing that can
sometimes cause the main memory bus to stop working, causing all
memory reads to return nothing but 0xFFFFFFFF, even though the memory
location was previously written.  After a while a privileged
instruction fault will appear and then nothing more can be debugged.
The reason for this behaviour is unknown.

MFC after:	1 week
This commit is contained in:
hselasky 2012-03-29 15:33:44 +00:00
parent 9cd12cd0b3
commit 6749f469aa
1 changed files with 21 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
sys/dev/pci/pci.c
View File

@ -2590,6 +2590,27 @@ pci_write_bar(device_t dev, struct pci_map *pm, pci_addr_t base)
struct pci_devinfo *dinfo;
int ln2range;
/*
* Don't disable BARs on AGP devices. In general: Don't
* disable BARs on any PCI display devices, because doing that
* can sometimes cause the main memory bus to stop working,
* causing all memory reads to return nothing but 0xFFFFFFFF,
* even though the memory location was previously written.
* After a while a privileged instruction fault will appear
* and then nothing more can be debugged.
* The reason for this behaviour is unknown.
*/
if (base == 0 && pci_get_class(dev) == PCIC_DISPLAY) {
device_printf(device_get_parent(dev),
"pci%d:%d:%d:%d BARs on display devices "
"should not be disabled.\n",
pci_get_domain(dev),
pci_get_bus(dev),
pci_get_slot(dev),
pci_get_function(dev));
return;
}
/* The device ROM BAR is always a 32-bit memory BAR. */
dinfo = device_get_ivars(dev);
if (PCIR_IS_BIOS(&dinfo->cfg, pm->pm_reg))