d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

do_file() is called recursively from several places and cannot

Browse Source 
safely free() anything related to items that may be recursed on.

Obtained from:	DragonFly (rev 1.7, dillon)
PR:		bin/94767
MFC After:	1 month
This commit is contained in:
Xin LI 2006-05-20 05:47:18 +00:00
parent 07b7d7fbdf
commit 67914dcded
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
sbin/rcorder/rcorder.c
View File

@ -722,6 +722,10 @@ keep_ok(fnode)
* is ok, we loop over the filenodes requirements, calling satisfy_req()
* for each of them.. once we have done this, remove this filenode
* from each provision table, as we are now done.
*
* NOTE: do_file() is called recursively from several places and cannot
* safely free() anything related to items that may be recursed on.
* Circular dependancies will cause problems if we do.
*/
void
do_file(fnode)
@ -757,8 +761,10 @@ do_file(fnode)
r_tmp = r;
satisfy_req(r, fnode->filename);
r = r->next;
#if 0
if (was_set == 0)
free(r_tmp);
free(r_tmp);
#endif
}
fnode->req_list = NULL;
@ -797,10 +803,12 @@ do_file(fnode)
}
DPRINTF((stderr, "nuking %s\n", fnode->filename));
#if 0
if (was_set == 0) {
free(fnode->filename);
free(fnode);
}
#endif
}
void