From 67eae018cb37a6be22997485b36a63f7060e379a Mon Sep 17 00:00:00 2001 From: Kris Kennaway Date: Mon, 26 Mar 2007 21:45:44 +0000 Subject: [PATCH] Remove unnecessary giant acquisition around panic in #ifdef DIAGNOSTIC code. # There is some question about whether this code is even relevant any # longer (it dates back to prehistoric times, i.e. present in r1.1), # especially on amd64. Reviewed by: jhb --- sys/amd64/amd64/trap.c | 2 -- sys/i386/i386/trap.c | 2 -- 2 files changed, 4 deletions(-) diff --git a/sys/amd64/amd64/trap.c b/sys/amd64/amd64/trap.c index a86df0c7682f..6c31c298496f 100644 --- a/sys/amd64/amd64/trap.c +++ b/sys/amd64/amd64/trap.c @@ -745,10 +745,8 @@ syscall(struct trapframe *frame) #ifdef DIAGNOSTIC if (ISPL(frame->tf_cs) != SEL_UPL) { - mtx_lock(&Giant); /* try to stabilize the system XXX */ panic("syscall"); /* NOT REACHED */ - mtx_unlock(&Giant); } #endif diff --git a/sys/i386/i386/trap.c b/sys/i386/i386/trap.c index cf25f9f304ff..d0eb30dd26c4 100644 --- a/sys/i386/i386/trap.c +++ b/sys/i386/i386/trap.c @@ -924,10 +924,8 @@ syscall(struct trapframe *frame) #ifdef DIAGNOSTIC if (ISPL(frame->tf_cs) != SEL_UPL) { - mtx_lock(&Giant); /* try to stabilize the system XXX */ panic("syscall"); /* NOT REACHED */ - mtx_unlock(&Giant); } #endif