d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Properly use the envp argument in execvPe().

Browse Source 
execvPe() is called by _execvpe(), which we added to implement
posix_spawnp(). We just took execvP() and added the envp argument.
Unfortunately we forgot to change the implementation to use envp over
environ.

This fixes the following piece of code:

| char * const arg[2] = { "env", NULL };
| char * const env[2] = { "FOO=BAR", NULL };
| posix_spawnp(NULL, "/usr/bin/env", NULL, NULL, arg, env);

MFC after:	2 weeks
This commit is contained in:
ed 2009-11-27 13:05:14 +00:00
parent 0f796b1cf4
commit 6909f7535e
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/libc/gen/exec.c
View File

@ -209,7 +209,7 @@ execvPe(name, path, argv, envp)
bcopy(name, buf + lp + 1, ln);
buf[lp + ln + 1] = '\0';
retry: (void)_execve(bp, argv, environ);
retry: (void)_execve(bp, argv, envp);
switch (errno) {
case E2BIG:
goto done;
@ -228,7 +228,7 @@ retry: (void)_execve(bp, argv, environ);
memp[0] = "sh";
memp[1] = bp;
bcopy(argv + 1, memp + 2, cnt * sizeof(char *));
(void)_execve(_PATH_BSHELL, memp, environ);
(void)_execve(_PATH_BSHELL, memp, envp);
goto done;
case ENOMEM:
goto done;