From 6b3ee24839eb85415d40d4adc1f79f0c936c9db7 Mon Sep 17 00:00:00 2001 From: Andriy Gapon <avg@FreeBSD.org> Date: Mon, 31 May 2010 09:08:44 +0000 Subject: [PATCH] udf_readlink: fix malloc call with uninitialized size parameter Found by: clang static analyzer MFC after: 4 days --- sys/fs/udf/udf_vnops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/fs/udf/udf_vnops.c b/sys/fs/udf/udf_vnops.c index 32010008d83f..ac00b2032c1f 100644 --- a/sys/fs/udf/udf_vnops.c +++ b/sys/fs/udf/udf_vnops.c @@ -904,9 +904,9 @@ udf_readlink(struct vop_readlink_args *ap) vp = ap->a_vp; node = VTON(vp); len = le64toh(node->fentry->inf_len); + iov[0].iov_len = len; buf = malloc(iov[0].iov_len, M_DEVBUF, M_WAITOK); iov[0].iov_base = buf; - iov[0].iov_len = len; uio.uio_iov = iov; uio.uio_iovcnt = 1; uio.uio_offset = 0;