d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

camcontrol: change hueristic for I/O-less devtype

Browse Source 
Some SATA drives have 'config' set to 0 in the identify block. Rather than rely
on it, use the strings windows uses to display the drive since they are supposed
to be space padded and will always be non-zero.
This commit is contained in:
Warner Losh 2021-02-23 12:33:26 -07:00
parent ef1a1fc7e8
commit 6b7580f7b1
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
sbin/camcontrol/camcontrol.c
View File

@ -5520,9 +5520,14 @@ get_device_type(struct cam_device *dev, int retry_count, int timeout,
* For a retry count of -1, used only the cached data to avoid
* I/O to the drive. Sending the identify command to the drive
* can cause issues for SATL attachaed drives since identify is
* not an NCQ command.
* not an NCQ command. We check for the strings that windows
* displays since those will not be NULs (they are supposed
* to be space padded). We could check other bits, but anything
* non-zero implies SATL.
*/
if (cgd.ident_data.config != 0)
if (cgd.ident_data.serial[0] != 0 ||
cgd.ident_data.revision[0] != 0 ||
cgd.ident_data.model[0] != 0)
*devtype = CC_DT_SATL;
else
*devtype = CC_DT_SCSI;