d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove two bzero()s that are erasing only few more bytes then set later.

Browse Source
This commit is contained in:
Alexander Motin 2013-03-25 06:31:17 +00:00
parent 30ba747160
commit 6d14d0d010
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
sys/cam/ata/ata_all.c
View File

@ -367,7 +367,7 @@ void
ata_48bit_cmd(struct ccb_ataio *ataio, uint8_t cmd, uint16_t features, ata_48bit_cmd(struct ccb_ataio *ataio, uint8_t cmd, uint16_t features,
uint64_t lba, uint16_t sector_count) uint64_t lba, uint16_t sector_count)
{ {
bzero(&ataio->cmd, sizeof(ataio->cmd));
ataio->cmd.flags = CAM_ATAIO_48BIT; ataio->cmd.flags = CAM_ATAIO_48BIT;
if (cmd == ATA_READ_DMA48 || if (cmd == ATA_READ_DMA48 ||
cmd == ATA_READ_DMA_QUEUED48 || cmd == ATA_READ_DMA_QUEUED48 ||
@ -391,13 +391,14 @@ ata_48bit_cmd(struct ccb_ataio *ataio, uint8_t cmd, uint16_t features,
ataio->cmd.features_exp = features >> 8; ataio->cmd.features_exp = features >> 8;
ataio->cmd.sector_count = sector_count; ataio->cmd.sector_count = sector_count;
ataio->cmd.sector_count_exp = sector_count >> 8; ataio->cmd.sector_count_exp = sector_count >> 8;
ataio->cmd.control = 0;
} }
void void
ata_ncq_cmd(struct ccb_ataio *ataio, uint8_t cmd, ata_ncq_cmd(struct ccb_ataio *ataio, uint8_t cmd,
uint64_t lba, uint16_t sector_count) uint64_t lba, uint16_t sector_count)
{ {
bzero(&ataio->cmd, sizeof(ataio->cmd));
ataio->cmd.flags = CAM_ATAIO_48BIT | CAM_ATAIO_FPDMA; ataio->cmd.flags = CAM_ATAIO_48BIT | CAM_ATAIO_FPDMA;
ataio->cmd.command = cmd; ataio->cmd.command = cmd;
ataio->cmd.features = sector_count; ataio->cmd.features = sector_count;
@ -409,6 +410,9 @@ ata_ncq_cmd(struct ccb_ataio *ataio, uint8_t cmd,
ataio->cmd.lba_mid_exp = lba >> 32; ataio->cmd.lba_mid_exp = lba >> 32;
ataio->cmd.lba_high_exp = lba >> 40; ataio->cmd.lba_high_exp = lba >> 40;
ataio->cmd.features_exp = sector_count >> 8; ataio->cmd.features_exp = sector_count >> 8;
ataio->cmd.sector_count = 0;
ataio->cmd.sector_count_exp = 0;
ataio->cmd.control = 0;
} }
void void