d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

MFC r308772: crunchide: report explicit error for combined string table

Browse Source 
Some tools produce objects with a combined strtab and shstrtab.
These objects are not supported by crunchide since it rewrites the
symtab and strtab to "hide" symbols. This invalidates section header
offsets into a combined strtab/shstrtab.

In the future we could support these objects (by ensuring that we retain
unmodified section name strings in the output .strtab, and then rewriting
each section header's sh_name).
This commit is contained in:
Ed Maste 2016-11-24 00:45:00 +00:00
parent 8402b80dc2
commit 6edb8140ad
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
usr.sbin/crunch/crunchide/exec_elf32.c
View File

@ -279,6 +279,10 @@ ELFNAMEEND(hide)(int fd, const char *fn)
weird = 1;
weirdreason = "section header string table does not exist";
}
if (strtabshdr == shstrtabshdr) {
weird = 1;
weirdreason = "combined strtab and shstrtab not supported";
}
if (weirdreason == NULL)
weirdreason = "unsupported";
if (weird) {