d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

I Noticed a defect in the way wakeup() scans the tailq. Tor noticed an

Browse Source 
even worse defect in wakeup_one().  This patch cleans up both.

Submitted by:	tegge
MFC after:	3 days
This commit is contained in:
Matthew Dillon 2002-06-24 00:14:36 +00:00
parent 99cfc2e2b2
commit 727300861d
1 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
sys/kern/kern_synch.c
View File

@ -606,12 +606,14 @@ wakeup(ident)
{
register struct slpquehead *qp;
register struct thread *td;
struct thread *ntd;
struct proc *p;
mtx_lock_spin(&sched_lock);
qp = &slpque[LOOKUP(ident)];
restart:
TAILQ_FOREACH(td, qp, td_slpq) {
for (td = TAILQ_FIRST(qp); td != NULL; td = ntd) {
ntd = TAILQ_NEXT(td, td_slpq);
p = td->td_proc;
if (td->td_wchan == ident) {
TAILQ_REMOVE(qp, td, td_slpq);
@ -652,11 +654,13 @@ wakeup_one(ident)
register struct slpquehead *qp;
register struct thread *td;
register struct proc *p;
struct thread *ntd;
mtx_lock_spin(&sched_lock);
qp = &slpque[LOOKUP(ident)];
TAILQ_FOREACH(td, qp, td_slpq) {
restart:
for (td = TAILQ_FIRST(qp); td != NULL; td = ntd) {
ntd = TAILQ_NEXT(td, td_slpq);
p = td->td_proc;
if (td->td_wchan == ident) {
TAILQ_REMOVE(qp, td, td_slpq);
@ -679,6 +683,7 @@ wakeup_one(ident)
wakeup((caddr_t)&proc0);
}
/* END INLINE EXPANSION */
goto restart;
}
}
}