d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Slightly improve previous commit that silenced a Clang Scan warning.

Browse Source 
The strdup() call does not take advantage of the known length of the
source string. Replace by malloc() and memcpy() utilizimng the pre-
calculated string length.

Submitted by:	cperciva
Reported by:	rgrimes
MFC after:	2 weeks
This commit is contained in:
se 2019-01-26 22:24:15 +00:00
parent 4045e6e64f
commit 72986d9f4b
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lib/libfigpar/string_m.c
View File

@ -119,9 +119,10 @@ replaceall(char *source, const char *find, const char *replace)
/* If replace is longer than find, we'll need to create a temp copy */ /* If replace is longer than find, we'll need to create a temp copy */
if (rlen > flen) { if (rlen > flen) {
temp = strdup(source); temp = malloc(slen + 1);
if (temp == NULL) /* could not allocate memory */ if (temp == NULL) /* could not allocate memory */
return (-1); return (-1);
memcpy(temp, source, slen + 1);
} else } else
temp = source; temp = source;