d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix uselocale(3) to not leak a reference to the old locale.

Browse Source 
In a single-threaded program pthread_getspecific() always returns NULL,
so the old locale would not end up being freed.

PR:		239520
MFC after:	2 weeks
Sponsored by:	The FreeBSD Foundation
This commit is contained in:
Mark Johnston 2020-03-20 20:02:53 +00:00
parent c09f243a5c
commit 733983be9b
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/libc/locale/xlocale.c
View File

@ -163,7 +163,7 @@ set_thread_locale(locale_t loc)
if (NULL != l) {
xlocale_retain((struct xlocale_refcounted*)l);
}
locale_t old = pthread_getspecific(locale_info_key);
locale_t old = get_thread_locale();
if ((NULL != old) && (l != old)) {
xlocale_release((struct xlocale_refcounted*)old);
}