d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

OF_getencprop_alloc shouldn't be used to get string value. If string

Browse Source 
length + 1 is not divisible by 4 this function returns NULL property
value. Otherwise - string with each 4 letters inverted
This commit is contained in:
Oleksandr Tymoshenko 2015-07-25 00:58:50 +00:00
parent 86236bd339
commit 7339f7821b
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
sys/dev/ofw/ofw_bus_subr.c
View File

@ -395,7 +395,7 @@ ofw_bus_reg_to_rl(device_t dev, phandle_t node, pcell_t acells, pcell_t scells,
* This may be just redundant when having ofw_bus_devinfo
* but makes this routine independent of it.
*/
ret = OF_getencprop_alloc(node, "name", sizeof(*name), (void **)&name);
ret = OF_getprop_alloc(node, "name", sizeof(*name), (void **)&name);
if (ret == -1)
name = NULL;
@ -511,7 +511,7 @@ ofw_bus_find_child(phandle_t start, const char *child_name)
phandle_t child;
for (child = OF_child(start); child != 0; child = OF_peer(child)) {
ret = OF_getencprop_alloc(child, "name", sizeof(*name), (void **)&name);
ret = OF_getprop_alloc(child, "name", sizeof(*name), (void **)&name);
if (ret == -1)
continue;
if (strcmp(name, child_name) == 0) {