d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

(1) Removed the bogus condition "p->p_pid != 1" on calling sched_exit()

Browse Source 
from exit1().  sched_exit() must be called unconditionally from exit1().
    It was called almost unconditionally because the only exits on system
    shutdown if at all.

(2) Removed the comment that presumed to know what sched_exit() does.
    sched_exit() does different things for the ULE case.  The call became
    essential when it started doing load average stuff, but its caller
    should not know that.

(3) Didn't fix bugs caused by bitrot in the condition.  The condition was
    last correct in rev.1.208 when it was in wait1().  There p was spelled
    curthread->td_proc and was for the waiting parent; now p is for the
    exiting child.  The condition was to avoid lowering init's priority.
    It should be in sched_exit() itself.  Lowering of priorities is broken
    in other ways in at least the 4BSD scheduler, and doing it for init
    causes less noticeable problems than doing it for for shells.

Noticed by:	julian (1)
This commit is contained in:
bde 2004-06-21 14:49:50 +00:00
parent a3821a72ca
commit 747f331358
1 changed files with 1 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
sys/kern/kern_exit.c
View File

@ -527,13 +527,7 @@ exit1(struct thread *td, int rv)
PCPU_SET(switchticks, ticks);
cnt.v_swtch++;
/*
* Allow the scheduler to adjust the priority of the
* parent when a kseg is exiting.
*/
if (p->p_pid != 1)
sched_exit(p->p_pptr, p);
sched_exit(p->p_pptr, p);
/*
* Make sure the scheduler takes this thread out of its tables etc.