d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

* Fix use-after-free in table printing code.

Browse Source 
* Fix showing human-readable error in table cmds code.
This commit is contained in:
melifaro 2014-10-09 12:54:56 +00:00
parent 66120268e5
commit 7740b8f739
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
sbin/ipfw/tables.c
View File

@ -1018,6 +1018,8 @@ table_modify_record(ipfw_obj_header *oh, int ac, char *av[], int add,
if (error == 0)
return;
/* Get real OS error */
error = errno;
/* Try to provide more human-readable error */
switch (error) {
@ -1551,12 +1553,11 @@ tables_foreach(table_cb_t *f, void *arg, int sort)
olh->size = sz;
if (do_get3(IP_FW_TABLES_XLIST, &olh->opheader, &sz) != 0) {
sz = olh->size;
free(olh);
if (errno == ENOMEM) {
sz = olh->size;
continue;
}
return (errno);
if (errno != ENOMEM)
return (errno);
continue;
}
if (sort != 0)