d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

xen-netfront: remove pointless assignment in xn_ioctl

Browse Source 
The variable error is assigned to 0 before entering the switch.
Assigning error to 0 before break pointless rewrites the real error
value that should be returned.

Coverity ID:		1304974
Submitted by:		Wei Liu <wei.liu2@citrix.com>
Reviewed by:		royger
Sponsored by:		Citrix Systems R&D
Differential revision:	https://reviews.freebsd.org/D5250
This commit is contained in:
Roger Pau Monné 2016-02-11 11:50:31 +00:00
parent 647a3bac7e
commit 7803499440
1 changed files with 0 additions and 2 deletions

2
sys/dev/xen/netfront/netfront.c

@ -1863,7 +1863,6 @@ xn_ioctl(struct ifnet *ifp, u_long cmd, caddr_t data)
}
sc->xn_if_flags = ifp->if_flags;
XN_UNLOCK(sc);
error = 0;
break;
case SIOCSIFCAP:
mask = ifr->ifr_reqcap ^ ifp->if_capenable;
@ -1898,7 +1897,6 @@ xn_ioctl(struct ifnet *ifp, u_long cmd, caddr_t data)
ifp->if_capenable ^= IFCAP_LRO;
}
error = 0;
break;
case SIOCADDMULTI:
case SIOCDELMULTI: