d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Plug a file descriptor leak.

Browse Source 
When sed is asked to inline-edit files, it forgets to close the temporary
file and runs out of descriptors for long command lines (assuming you reset
kern.maxfilesperproc to something sane that's less than the number of files
passed to sed).
This commit is contained in:
Brian Somers 2004-06-03 22:33:50 +00:00
parent b2cd42638f
commit 7bbdbe1482
1 changed files with 13 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
usr.bin/sed/main.c
View File

@ -327,15 +327,21 @@ mf_fgets(SPACE *sp, enum e_spflag spflag)
}
if (infile != NULL) {
fclose(infile);
if (*oldfname != '\0' &&
rename(fname, oldfname) != 0) {
warn("rename()");
unlink(tmpfname);
exit(1);
if (*oldfname != '\0') {
if (rename(fname, oldfname) != 0) {
warn("rename()");
unlink(tmpfname);
exit(1);
}
*oldfname = '\0';
}
if (*tmpfname != '\0')
if (*tmpfname != '\0') {
if (outfile != NULL && outfile != stdout)
fclose(outfile);
outfile = NULL;
rename(tmpfname, fname);
*tmpfname = *oldfname = '\0';
*tmpfname = '\0';
}
outfname = NULL;
}
if (firstfile == 0)