d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

sh: Fix copying uninitialized field 'special'.

Browse Source 
This just copied uninitialized data and did not depend on it later, so it
should not be dangerous.

Found by:	clang static analyzer
This commit is contained in:
Jilles Tjoelker 2016-03-13 22:54:14 +00:00
parent 19edab1711
commit 7d980385e8
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
bin/sh/exec.c
View File

@ -332,6 +332,7 @@ find_command(const char *name, struct cmdentry *entry, int act,
if (strchr(name, '/') != NULL) { if (strchr(name, '/') != NULL) {
entry->cmdtype = CMDNORMAL; entry->cmdtype = CMDNORMAL;
entry->u.index = 0; entry->u.index = 0;
entry->special = 0;
return; return;
} }
@ -408,6 +409,7 @@ find_command(const char *name, struct cmdentry *entry, int act,
cmdp = &loc_cmd; cmdp = &loc_cmd;
cmdp->cmdtype = CMDNORMAL; cmdp->cmdtype = CMDNORMAL;
cmdp->param.index = idx; cmdp->param.index = idx;
cmdp->special = 0;
INTON; INTON;
goto success; goto success;
} }
@ -420,6 +422,7 @@ find_command(const char *name, struct cmdentry *entry, int act,
} }
entry->cmdtype = CMDUNKNOWN; entry->cmdtype = CMDUNKNOWN;
entry->u.index = 0; entry->u.index = 0;
entry->special = 0;
return; return;
success: success:
@ -588,6 +591,7 @@ addcmdentry(const char *name, struct cmdentry *entry)
} }
cmdp->cmdtype = entry->cmdtype; cmdp->cmdtype = entry->cmdtype;
cmdp->param = entry->u; cmdp->param = entry->u;
cmdp->special = entry->special;
INTON; INTON;
} }
@ -604,6 +608,7 @@ defun(const char *name, union node *func)
INTOFF; INTOFF;
entry.cmdtype = CMDFUNCTION; entry.cmdtype = CMDFUNCTION;
entry.u.func = copyfunc(func); entry.u.func = copyfunc(func);
entry.special = 0;
addcmdentry(name, &entry); addcmdentry(name, &entry);
INTON; INTON;
} }