Remove call to access(2) which didn't serve any purpose, and make it more

tolerant to errors.

MFC after:	1 month
Sponsored by:	The FreeBSD Foundation
This commit is contained in:
Edward Tomasz Napierala 2014-10-07 19:08:02 +00:00
parent 4c62148d7b
commit 7ebeea9aa6

View File

@ -169,17 +169,12 @@ create_directory(const char *path)
if (component == NULL)
break;
concat(&partial, &component);
//log_debugx("checking \"%s\" for existence", partial);
error = access(partial, F_OK);
if (error == 0)
continue;
if (errno != ENOENT)
log_err(1, "cannot access %s", partial);
log_debugx("directory %s does not exist, creating",
partial);
//log_debugx("creating \"%s\"", partial);
error = mkdir(partial, 0755);
if (error != 0)
log_err(1, "cannot create %s", partial);
if (error != 0 && errno != EEXIST) {
log_warn("cannot create %s", partial);
return;
}
}
free(tofree);