d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Use an array of size NGROUP_MAX for the getgroups() call instead of NGRP.

Browse Source 
When NGROUP_MAX is larger than NGRP the call used to fail. Now the call
succeedes, but only the first NGRP groups are actually used for authentication.
This commit is contained in:
harti 2007-06-14 20:07:35 +00:00
parent f1a585dc51
commit 8016b195e6
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/libc/rpc/auth_unix.c
View File

@ -189,15 +189,17 @@ authunix_create_default()
char machname[MAXHOSTNAMELEN + 1];
uid_t uid;
gid_t gid;
gid_t gids[NGRPS];
gid_t gids[NGROUPS_MAX];
if (gethostname(machname, sizeof machname) == -1)
abort();
machname[sizeof(machname) - 1] = 0;
uid = geteuid();
gid = getegid();
if ((len = getgroups(NGRPS, gids)) < 0)
if ((len = getgroups(NGROUPS_MAX, gids)) < 0)
abort();
if (len > NGRPS)
len = NGRPS;
/* XXX: interface problem; those should all have been unsigned */
return (authunix_create(machname, (int)uid, (int)gid, len,
(int *)gids));