d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix a bug reported by coverity. Since AF_UNIX sockets don't

Browse Source 
have multiple addresses, the problem didn't show up during testing.

Reported by:	Coverity
CID:		1306787
This commit is contained in:
Michael Tuexen 2015-06-18 13:45:07 +00:00
parent 872b4ed5ea
commit 8109120283
1 changed files with 10 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
usr.bin/sockstat/sockstat.c
View File

@ -865,6 +865,7 @@ displaysock(struct sock *s, int pos)
void *p;
int hash;
struct addr *laddr, *faddr;
struct sock *s_tmp;
while (pos < 29)
pos += xprintf(" ");
@ -908,18 +909,20 @@ displaysock(struct sock *s, int pos)
}
pos += xprintf("-> ");
for (hash = 0; hash < HASHSIZE; ++hash) {
for (s = sockhash[hash]; s != NULL; s = s->next)
if (s->pcb == p)
for (s_tmp = sockhash[hash];
s_tmp != NULL;
s_tmp = s_tmp->next)
if (s_tmp->pcb == p)
break;
if (s != NULL)
if (s_tmp != NULL)
break;
}
if (s == NULL ||
s->laddr == NULL ||
s->laddr->address.ss_len == 0)
if (s_tmp == NULL ||
s_tmp->laddr == NULL ||
s_tmp->laddr->address.ss_len == 0)
pos += xprintf("??");
else
pos += printaddr(&s->laddr->address);
pos += printaddr(&s_tmp->laddr->address);
break;
default:
abort();