d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

I've fixed the X11 port, so I can remove the (ioctl) hack.

Browse Source 
This hack turns out to be a bad idea.  Many auto configuration scripts
will #include a bunch of system headers, run it through cpp and then
grep/sed to see if there was really a prototype.  The regular
expressions that are used to test this didn't accept all possible
legal ANSI-C prototypes.  In particular, they didn't accept the ()
around ioctl.  Several different programs do this, so eliminating the
parans will keep FreeBSD maximally compatible with other systems.

Appologies to: obrien (he was right in the end)

This potentally breaks some ports (and fixes vim and others that
haven't been fixed to deal with the parens).
This commit is contained in:
Warner Losh 2002-04-10 04:53:37 +00:00
parent ee0a4f7ee7
commit 81f027f8fe
1 changed files with 1 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
sys/sys/ioccom.h
View File

@ -67,12 +67,7 @@
#include <sys/cdefs.h>
__BEGIN_DECLS
/*
* use parens around the ioctl so that people can define ioctl as a macro.
* Note: This will go away in the future, as soon as the current abusers
* have been fixed.
*/
int (ioctl)(int, unsigned long, ...);
int ioctl(int, unsigned long, ...);
__END_DECLS
#endif