From 82af5353b069bba7a516739631df1ce2231f5304 Mon Sep 17 00:00:00 2001 From: Warner Losh Date: Mon, 10 Jan 2000 06:17:27 +0000 Subject: [PATCH] Add some comments about things that have become bad as I've been working on this code, or things that I think are layering violations. Plus a minor whitespace cleanup in one place while I'm at it. --- sys/dev/pcic/i82365.c | 4 +++- sys/dev/pcic/i82365var.h | 4 ++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/sys/dev/pcic/i82365.c b/sys/dev/pcic/i82365.c index c51cc5e8de58..f78f8e1ef5a0 100644 --- a/sys/dev/pcic/i82365.c +++ b/sys/dev/pcic/i82365.c @@ -50,6 +50,8 @@ #include #include +/* We shouldn't need to include the following, but sadly we do for now */ +/* XXX */ #include #include @@ -738,7 +740,7 @@ pcic_deactivate_card(struct pcic_handle *h) } static int -pcic_chip_mem_alloc(struct pcic_handle *h, bus_size_t size, +pcic_chip_mem_alloc(struct pcic_handle *h, bus_size_t size, struct pccard_mem_handle *pcmhp) { bus_space_handle_t memh; diff --git a/sys/dev/pcic/i82365var.h b/sys/dev/pcic/i82365var.h index c4a543336477..0286beb9b740 100644 --- a/sys/dev/pcic/i82365var.h +++ b/sys/dev/pcic/i82365var.h @@ -59,9 +59,9 @@ struct pcic_handle { int flags; int laststate; int memalloc; - struct pccard_mem_handle mem[PCIC_MEM_WINS]; + struct pccard_mem_handle mem[PCIC_MEM_WINS]; /* XXX BAD XXX */ int ioalloc; - struct pccard_io_handle io[PCIC_IO_WINS]; + struct pccard_io_handle io[PCIC_IO_WINS]; /* XXX BAD XXX */ int ih_irq; int shutdown;