d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

pms(4): Do not return CAM_REQ_CMP on errors.

Browse Source 
It is a direct request for data corruptions, one report of which we
have received.  I am very surprised that only one.

MFC after:	1 week
Sponsored by:	iXsystems, Inc.
This commit is contained in:
Alexander Motin 2021-04-16 15:16:09 -04:00
parent e47823b831
commit 8434a65ce4
1 changed files with 11 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
sys/dev/pms/freebsd/driver/ini/src/agtiapi.c
View File

@ -2629,9 +2629,11 @@ static void agtiapi_PrepareSGListCB( void *arg,
{
AGTIAPI_PRINTK("agtiapi_PrepareSGListCB: error status 0x%x\n", error);
bus_dmamap_unload(pmcsc->buffer_dmat, pccb->CCB_dmamap);
bus_dmamap_destroy(pmcsc->buffer_dmat, pccb->CCB_dmamap);
agtiapi_FreeCCB(pmcsc, pccb);
ccb->ccb_h.status = CAM_REQ_CMP;
if (error == EFBIG)
ccb->ccb_h.status = CAM_REQ_TOO_BIG;
else
ccb->ccb_h.status = CAM_REQ_CMP_ERR;
xpt_done(ccb);
return;
}
@ -2643,9 +2645,8 @@ static void agtiapi_PrepareSGListCB( void *arg,
" AGTIAPI_MAX_DMA_SEGS %d\n",
nsegs, AGTIAPI_MAX_DMA_SEGS );
bus_dmamap_unload(pmcsc->buffer_dmat, pccb->CCB_dmamap);
bus_dmamap_destroy(pmcsc->buffer_dmat, pccb->CCB_dmamap);
agtiapi_FreeCCB(pmcsc, pccb);
ccb->ccb_h.status = CAM_REQ_CMP;
ccb->ccb_h.status = CAM_REQ_TOO_BIG;
xpt_done(ccb);
return;
}
@ -3689,9 +3690,11 @@ static void agtiapi_PrepareSMPSGListCB( void *arg,
AGTIAPI_PRINTK( "agtiapi_PrepareSMPSGListCB: error status 0x%x\n",
error );
bus_dmamap_unload( pmcsc->buffer_dmat, pccb->CCB_dmamap );
bus_dmamap_destroy( pmcsc->buffer_dmat, pccb->CCB_dmamap );
agtiapi_FreeCCB( pmcsc, pccb );
ccb->ccb_h.status = CAM_REQ_CMP;
if (error == EFBIG)
ccb->ccb_h.status = CAM_REQ_TOO_BIG;
else
ccb->ccb_h.status = CAM_REQ_CMP_ERR;
xpt_done( ccb );
return;
}
@ -3703,9 +3706,8 @@ static void agtiapi_PrepareSMPSGListCB( void *arg,
"AGTIAPI_MAX_DMA_SEGS %d\n",
nsegs, AGTIAPI_MAX_DMA_SEGS );
bus_dmamap_unload( pmcsc->buffer_dmat, pccb->CCB_dmamap );
bus_dmamap_destroy( pmcsc->buffer_dmat, pccb->CCB_dmamap );
agtiapi_FreeCCB( pmcsc, pccb );
ccb->ccb_h.status = CAM_REQ_CMP;
ccb->ccb_h.status = CAM_REQ_TOO_BIG;
xpt_done( ccb );
return;
}
@ -4410,7 +4412,7 @@ static int agtiapi_QueueSMP(struct agtiapi_softc *pmcsc, union ccb * ccb)
if ((pccb = agtiapi_GetCCB(pmcsc)) == NULL)
{
AGTIAPI_PRINTK("agtiapi_QueueSMP: GetCCB ERROR\n");
ccb->ccb_h.status = CAM_REQ_CMP;
ccb->ccb_h.status = CAM_REQ_CMP_ERR;
xpt_done(ccb);
return tiBusy;
}