d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mountroot: run statfs after mounting devfs

Browse Source 
The usual flow for mounting a file system is to VFS_MOUNT() and then
immediately VFS_STATFS().

That's not done in vfs_mountroot_devfs(), which means the
mp->mnt_stat.f_iosize field is not correctly populated, which in turn
causes us to mark valid aio operations as unsafe (because the io size is
set to 0), ultimately causing the aio_test:md_waitcomplete test to fail.

Reviewed by:	mckusick
MFC after:	1 week
Sponsored by:	Axiado
Differential Revision:	https://reviews.freebsd.org/D21897
This commit is contained in:
Kristof Provost 2019-10-11 17:04:38 +00:00
parent d0a9542494
commit 85d1151f96
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
sys/kern/vfs_mountroot.c
View File

@ -263,6 +263,11 @@ vfs_mountroot_devfs(struct thread *td, struct mount **mpp)
if (error)
return (error);
error = VFS_STATFS(mp, &mp->mnt_stat);
KASSERT(error == 0, ("VFS_STATFS(devfs) failed %d", error));
if (error)
return (error);
opts = malloc(sizeof(struct vfsoptlist), M_MOUNT, M_WAITOK);
TAILQ_INIT(opts);
mp->mnt_opt = opts;