d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Check strdup() return values

Browse Source 
Reviewed by:	kris
This commit is contained in:
Chris D. Faulhaber 2001-01-20 00:26:32 +00:00
parent c85c46678d
commit 8728c621a0
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
usr.bin/finger/util.c
View File

@ -353,9 +353,12 @@ userinfo(pn, pw)
pn->realname = pn->office = pn->officephone = pn->homephone = NULL; pn->realname = pn->office = pn->officephone = pn->homephone = NULL;
pn->uid = pw->pw_uid; pn->uid = pw->pw_uid;
pn->name = strdup(pw->pw_name); if ((pn->name = strdup(pw->pw_name)) == NULL)
pn->dir = strdup(pw->pw_dir); err(1, "strdup failed");
pn->shell = strdup(pw->pw_shell); if ((pn->dir = strdup(pw->pw_dir)) == NULL)
err(1, "strdup failed");
if ((pn->shell = strdup(pw->pw_shell)) == NULL)
err(1, "strdup failed");
/* why do we skip asterisks!?!? */ /* why do we skip asterisks!?!? */
(void)strncpy(bp = tbuf, pw->pw_gecos, sizeof(tbuf)); (void)strncpy(bp = tbuf, pw->pw_gecos, sizeof(tbuf));
@ -380,7 +383,8 @@ userinfo(pn, pw)
} }
} }
*t = '\0'; *t = '\0';
pn->realname = strdup(name); if ((pn->realname = strdup(name)) == NULL)
err(1, "strdup failed");
pn->office = ((p = strsep(&bp, ",")) && *p) ? pn->office = ((p = strsep(&bp, ",")) && *p) ?
strdup(p) : NULL; strdup(p) : NULL;
pn->officephone = ((p = strsep(&bp, ",")) && *p) ? pn->officephone = ((p = strsep(&bp, ",")) && *p) ?