Change the test at the beginning of strncmp(), from being if (len - 1) < 0
to if (len == 0). The length is supposed to be unsigned, so len - 1 < 0 won't happen except if len == 0 anyway, and it would return 0 when it shouldn't, if len was > INT_MAX. Spotted out by: Channa <channa kad gmail com>
This commit is contained in:
parent
33c70d417e
commit
8957464be7
@ -33,10 +33,10 @@
|
||||
__FBSDID("$FreeBSD$");
|
||||
|
||||
ENTRY(strncmp)
|
||||
/* if ((len - 1) < 0) return 0 */
|
||||
subs r2, r2, #1
|
||||
movmi r0, #0
|
||||
movmi pc, lr
|
||||
/* if (len == 0) return 0 */
|
||||
cmp r2, #0
|
||||
moveq r0, #0
|
||||
RETeq
|
||||
|
||||
/* ip == last src address to compare */
|
||||
add ip, r0, r2
|
||||
|
Loading…
Reference in New Issue
Block a user