From 8e41399c8ff909fdf57476e0a2cc2e1e29967a6d Mon Sep 17 00:00:00 2001 From: Brian Somers Date: Sun, 19 Jul 2009 19:01:30 +0000 Subject: [PATCH] Don't get stuck in an infinite loop comparing (short++ <= maxshort) PR: 136893 Submitted by: Aragon Gouveia - aragon at phat dot za dot net (mostly) Approved by: re (kib) MFC after: 3 weeks --- usr.sbin/ppp/nat_cmd.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/usr.sbin/ppp/nat_cmd.c b/usr.sbin/ppp/nat_cmd.c index b4d6ad29377b..48f894aedc47 100644 --- a/usr.sbin/ppp/nat_cmd.c +++ b/usr.sbin/ppp/nat_cmd.c @@ -175,7 +175,7 @@ nat_RedirectPort(struct cmdargs const *arg) return -1; } - while (laliasport <= haliasport) { + do { link = LibAliasRedirectPort(la, localaddr, htons(llocalport), remoteaddr, htons(lremoteport), aliasaddr, htons(laliasport), @@ -187,10 +187,9 @@ nat_RedirectPort(struct cmdargs const *arg) return 1; } llocalport++; - laliasport++; if (hremoteport) lremoteport++; - } + } while (laliasport++ < haliasport); return 0; }