From 8ecd20c6f7541f59d71ab745ffb5703c207ffd58 Mon Sep 17 00:00:00 2001 From: rwatson Date: Sat, 26 Jun 2004 17:12:29 +0000 Subject: [PATCH] Replace comment on spl state when calling soabort() with a comment on locking state. No socket locks should be held when calling soabort() as it will call into protocol code that may acquire socket locks. --- sys/kern/uipc_socket.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/sys/kern/uipc_socket.c b/sys/kern/uipc_socket.c index 21ed07665872..16cb49eb5373 100644 --- a/sys/kern/uipc_socket.c +++ b/sys/kern/uipc_socket.c @@ -426,7 +426,10 @@ soclose(so) } /* - * Must be called at splnet... + * soabort() must not be called with any socket locks held, as it calls + * into the protocol, which will call back into the socket code causing + * it to acquire additional socket locks that may cause recursion or lock + * order reversals. */ int soabort(so)