d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Don't kill pid -1 on overflow from strtol(3).

Browse Source 
Store the result in a proper long and then compare to the proper pid_t
for overflow, so that no MD assumptions are made.

Reviewed by:	jilles
MFC after:	2 weeks
Differential Revision:	https://reviews.freebsd.org/D9887
This commit is contained in:
bdrewery 2017-03-05 21:56:04 +00:00
parent df721c248b
commit 908622a563
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
bin/kill/kill.c
View File

@ -66,7 +66,9 @@ static void usage(void);
int int
main(int argc, char *argv[]) main(int argc, char *argv[])
{ {
int errors, numsig, pid, ret; long pidl;
pid_t pid;
int errors, numsig, ret;
char *ep; char *ep;
if (argc < 2) if (argc < 2)
@ -137,8 +139,10 @@ main(int argc, char *argv[])
else else
#endif #endif
{ {
pid = strtol(*argv, &ep, 10); pidl = strtol(*argv, &ep, 10);
if (!**argv || *ep) /* Check for overflow of pid_t. */
pid = (pid_t)pidl;
if (!**argv || *ep || pid != pidl)
errx(2, "illegal process id: %s", *argv); errx(2, "illegal process id: %s", *argv);
ret = kill(pid, numsig); ret = kill(pid, numsig);
} }