d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fd: remove filedesc argument from fdclose

Browse Source 
Just accept a thread instead. This makes it consistent with fdalloc.

No functional changes.
This commit is contained in:
Mateusz Guzik 2015-04-11 15:40:28 +00:00
parent 3d08016fc4
commit 90f54cbfeb
13 changed files with 23 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
sys/compat/svr4/svr4_stream.c
View File

@ -1829,7 +1829,7 @@ svr4_do_getmsg(td, uap, fp)
break;
default:
fdclose(td->td_proc->p_fd, afp, st->s_afd, td);
fdclose(td, afp, st->s_afd);
fdrop(afp, td);
st->s_afd = -1;
mtx_unlock(&Giant);
@ -1967,7 +1967,7 @@ svr4_do_getmsg(td, uap, fp)
if (error) {
if (afp) {
fdclose(td->td_proc->p_fd, afp, st->s_afd, td);
fdclose(td, afp, st->s_afd);
fdrop(afp, td);
st->s_afd = -1;
}

4
sys/dev/streams/streams.c
View File

@ -180,7 +180,6 @@ MODULE_VERSION(streams, 1);
static int
streamsopen(struct cdev *dev, int oflags, int devtype, struct thread *td)
{
struct filedesc *fdp;
struct svr4_strm *st;
struct socket *so;
struct file *fp;
@ -236,14 +235,13 @@ streamsopen(struct cdev *dev, int oflags, int devtype, struct thread *td)
return EOPNOTSUPP;
}
fdp = td->td_proc->p_fd;
if ((error = falloc(td, &fp, &fd, 0)) != 0)
return error;
/* An extra reference on `fp' has been held for us by falloc(). */
error = socreate(family, &so, type, protocol, td->td_ucred, td);
if (error) {
fdclose(fdp, fp, fd, td);
fdclose(td, fp, fd);
fdrop(fp, td);
return error;
}

3
sys/kern/kern_descrip.c
View File

@ -2155,8 +2155,9 @@ fdsetugidsafety(struct thread *td)
* file descriptor out from under the thread creating the file object.
*/
void
fdclose(struct filedesc *fdp, struct file *fp, int idx, struct thread *td)
fdclose(struct thread *td, struct file *fp, int idx)
{
struct filedesc *fdp = td->td_proc->p_fd;
FILEDESC_XLOCK(fdp);
if (fdp->fd_ofiles[idx].fde_file == fp) {

2
sys/kern/kern_fork.c
View File

@ -949,7 +949,7 @@ fork1(struct thread *td, int flags, int pages, struct proc **procp,
vmspace_free(vm2);
uma_zfree(proc_zone, newproc);
if ((flags & RFPROCDESC) != 0 && fp_procdesc != NULL) {
fdclose(td->td_proc->p_fd, fp_procdesc, *procdescp, td);
fdclose(td, fp_procdesc, *procdescp);
fdrop(fp_procdesc, td);
}
pause("fork", hz / 2);

4
sys/kern/sys_pipe.c
View File

@ -406,13 +406,11 @@ kern_pipe(struct thread *td, int fildes[2])
int
kern_pipe2(struct thread *td, int fildes[2], int flags)
{
struct filedesc *fdp;
struct file *rf, *wf;
struct pipe *rpipe, *wpipe;
struct pipepair *pp;
int fd, fflags, error;
fdp = td->td_proc->p_fd;
pipe_paircreate(td, &pp);
rpipe = &pp->pp_rpipe;
wpipe = &pp->pp_wpipe;
@ -438,7 +436,7 @@ kern_pipe2(struct thread *td, int fildes[2], int flags)
finit(rf, fflags, DTYPE_PIPE, rpipe, &pipeops);
error = falloc(td, &wf, &fd, flags);
if (error) {
fdclose(fdp, rf, fildes[0], td);
fdclose(td, rf, fildes[0]);
fdrop(rf, td);
/* rpipe has been closed by fdrop(). */
pipeclose(wpipe);

2
sys/kern/tty_pts.c
View File

@ -845,7 +845,7 @@ sys_posix_openpt(struct thread *td, struct posix_openpt_args *uap)
/* Allocate the actual pseudo-TTY. */
error = pts_alloc(FFLAGS(uap->flags & O_ACCMODE), td, fp);
if (error != 0) {
fdclose(td->td_proc->p_fd, fp, fd, td);
fdclose(td, fp, fd);
fdrop(fp, td);
return (error);
}

2
sys/kern/uipc_mqueue.c
View File

@ -2022,7 +2022,7 @@ kern_kmq_open(struct thread *td, const char *upath, int flags, mode_t mode,
if (error) {
sx_xunlock(&mqfs_data.mi_lock);
fdclose(fdp, fp, fd, td);
fdclose(td, fp, fd);
fdrop(fp, td);
return (error);
}

6
sys/kern/uipc_sem.c
View File

@ -471,7 +471,7 @@ ksem_create(struct thread *td, const char *name, semid_t *semidp, mode_t mode,
*/
error = ksem_create_copyout_semid(td, semidp, fd, compat32);
if (error) {
fdclose(fdp, fp, fd, td);
fdclose(td, fp, fd);
fdrop(fp, td);
return (error);
}
@ -491,7 +491,7 @@ ksem_create(struct thread *td, const char *name, semid_t *semidp, mode_t mode,
if (error == 0 && path[0] != '/')
error = EINVAL;
if (error) {
fdclose(fdp, fp, fd, td);
fdclose(td, fp, fd);
fdrop(fp, td);
free(path, M_KSEM);
return (error);
@ -542,7 +542,7 @@ ksem_create(struct thread *td, const char *name, semid_t *semidp, mode_t mode,
if (error) {
KASSERT(ks == NULL, ("ksem_create error with a ksem"));
fdclose(fdp, fp, fd, td);
fdclose(td, fp, fd);
fdrop(fp, td);
return (error);
}

6
sys/kern/uipc_shm.c
View File

@ -718,7 +718,7 @@ sys_shm_open(struct thread *td, struct shm_open_args *uap)
if (uap->path == SHM_ANON) {
/* A read-only anonymous object is pointless. */
if ((uap->flags & O_ACCMODE) == O_RDONLY) {
fdclose(fdp, fp, fd, td);
fdclose(td, fp, fd);
fdrop(fp, td);
return (EINVAL);
}
@ -734,7 +734,7 @@ sys_shm_open(struct thread *td, struct shm_open_args *uap)
if (error == 0 && path[0] != '/')
error = EINVAL;
if (error) {
fdclose(fdp, fp, fd, td);
fdclose(td, fp, fd);
fdrop(fp, td);
free(path, M_SHMFD);
return (error);
@ -800,7 +800,7 @@ sys_shm_open(struct thread *td, struct shm_open_args *uap)
sx_xunlock(&shm_dict_lock);
if (error) {
fdclose(fdp, fp, fd, td);
fdclose(td, fp, fd);
fdrop(fp, td);
return (error);
}

11
sys/kern/uipc_syscalls.c
View File

@ -216,7 +216,7 @@ sys_socket(td, uap)
error = socreate(uap->domain, &so, type, uap->protocol,
td->td_ucred, td);
if (error != 0) {
fdclose(td->td_proc->p_fd, fp, fd, td);
fdclose(td, fp, fd);
} else {
finit(fp, FREAD | FWRITE | fflag, DTYPE_SOCKET, so, &socketops);
if ((fflag & FNONBLOCK) != 0)
@ -373,7 +373,7 @@ accept1(td, s, uname, anamelen, flags)
error = copyout(&namelen, anamelen,
sizeof(namelen));
if (error != 0)
fdclose(td->td_proc->p_fd, fp, td->td_retval[0], td);
fdclose(td, fp, td->td_retval[0]);
fdrop(fp, td);
free(name, M_SONAME);
return (error);
@ -520,7 +520,7 @@ kern_accept4(struct thread *td, int s, struct sockaddr **name,
* out from under us.
*/
if (error != 0)
fdclose(fdp, nfp, fd, td);
fdclose(td, nfp, fd);
/*
* Release explicitly held references before returning. We return
@ -683,7 +683,6 @@ int
kern_socketpair(struct thread *td, int domain, int type, int protocol,
int *rsv)
{
struct filedesc *fdp = td->td_proc->p_fd;
struct file *fp1, *fp2;
struct socket *so1, *so2;
int fd, error, oflag, fflag;
@ -747,10 +746,10 @@ kern_socketpair(struct thread *td, int domain, int type, int protocol,
fdrop(fp2, td);
return (0);
free4:
fdclose(fdp, fp2, rsv[1], td);
fdclose(td, fp2, rsv[1]);
fdrop(fp2, td);
free3:
fdclose(fdp, fp1, rsv[0], td);
fdclose(td, fp1, rsv[0]);
fdrop(fp1, td);
free2:
if (so2 != NULL)

2
sys/netinet/sctp_syscalls.c
View File

@ -187,7 +187,7 @@ sys_sctp_peeloff(td, uap)
* out from under us.
*/
if (error != 0)
fdclose(td->td_proc->p_fd, nfp, fd, td);
fdclose(td, nfp, fd);
/*
* Release explicitly held references before returning.

2
sys/ofed/include/linux/file.h
View File

@ -82,7 +82,7 @@ put_unused_fd(unsigned int fd)
* installed, so no need to free the associated Linux file
* structure.
*/
fdclose(curthread->td_proc->p_fd, file, fd, curthread);
fdclose(curthread, file, fd);
/* drop extra reference */
fdrop(file, curthread);

2
sys/sys/filedesc.h
View File

@ -152,7 +152,7 @@ int finstall(struct thread *td, struct file *fp, int *resultfp, int flags,
int fdalloc(struct thread *td, int minfd, int *result);
int fdallocn(struct thread *td, int minfd, int *fds, int n);
int fdcheckstd(struct thread *td);
void fdclose(struct filedesc *fdp, struct file *fp, int idx, struct thread *td);
void fdclose(struct thread *td, struct file *fp, int idx);
void fdcloseexec(struct thread *td);
void fdsetugidsafety(struct thread *td);
struct filedesc *fdcopy(struct filedesc *fdp);