d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add deprecation notice for bvmconsole and bvmdebug

Browse Source 
Now that bhyve(8) supports UART, bvmconsole and bvmdebug are no longer needed.

Mark the '-b' and '-g' flag as deprecated for bhyve(8).

These will be removed in 13.

Reviewed by:    jhb, grehan
Approved by:    kevans (mentor)
MFC after:      1 week
Differential Revision:  https://reviews.freebsd.org/D27519
This commit is contained in:
Robert Wing 2020-12-10 18:07:25 +00:00
parent fc89b27576
commit 92f7309929
4 changed files with 11 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
sys/dev/bvm/bvm_console.c
View File

@ -107,6 +107,8 @@ static void
cn_drvinit(void *unused) cn_drvinit(void *unused)
{ {
struct tty *tp; struct tty *tp;
gone_in(13, "bvmconsole");
if (bvm_consdev.cn_pri != CN_DEAD) { if (bvm_consdev.cn_pri != CN_DEAD) {
tp = tty_alloc(&bvm_ttydevsw, NULL); tp = tty_alloc(&bvm_ttydevsw, NULL);

2
sys/dev/bvm/bvm_dbg.c
View File

@ -61,6 +61,8 @@ bvm_dbg_probe(void)
disabled = 0; disabled = 0;
resource_int_value("bvmdbg", 0, "disabled", &disabled); resource_int_value("bvmdbg", 0, "disabled", &disabled);
gone_in(13, "bvmdebug");
if (!disabled) { if (!disabled) {
if (resource_int_value("bvmdbg", 0, "port", &port) == 0) if (resource_int_value("bvmdbg", 0, "port", &port) == 0)
bvm_dbg_port = port; bvm_dbg_port = port;

8
usr.sbin/bhyve/bhyve.8
View File

@ -24,7 +24,7 @@
.\" .\"
.\" $FreeBSD$ .\" $FreeBSD$
.\" .\"
.Dd Jun 25, 2020 .Dd December 8, 2020
.Dt BHYVE 8 .Dt BHYVE 8
.Os .Os
.Sh NAME .Sh NAME
@ -104,7 +104,8 @@ Enable a low-level console device supported by
.Fx .Fx
kernels compiled with kernels compiled with
.Cd "device bvmconsole" . .Cd "device bvmconsole" .
This option will be deprecated in a future version. This option is deprecated and will be removed in
.Fx 13.0 .
.It Fl c Op Ar setting ... .It Fl c Op Ar setting ...
Number of guest virtual CPUs Number of guest virtual CPUs
and/or the CPU topology. and/or the CPU topology.
@ -145,7 +146,8 @@ kernels compiled with
.Cd "device bvmdebug" , .Cd "device bvmdebug" ,
allow a remote kernel kgdb to be relayed to the guest kernel gdb stub allow a remote kernel kgdb to be relayed to the guest kernel gdb stub
via a local IPv4 address and this port. via a local IPv4 address and this port.
This option will be deprecated in a future version. This option is deprecated and will be removed in
.Fx 13.0 .
.It Fl G Ar port .It Fl G Ar port
Start a debug server that uses the GDB protocol to export guest state to a Start a debug server that uses the GDB protocol to export guest state to a
debugger. debugger.

2
usr.sbin/bhyve/bhyverun.c
View File

@ -1124,6 +1124,7 @@ main(int argc, char *argv[])
acpi = 1; acpi = 1;
break; break;
case 'b': case 'b':
warnx("-b flag is deprecated and will be removed in FreeBSD 13.0");
bvmcons = 1; bvmcons = 1;
break; break;
case 'D': case 'D':
@ -1145,6 +1146,7 @@ main(int argc, char *argv[])
memflags |= VM_MEM_F_INCORE; memflags |= VM_MEM_F_INCORE;
break; break;
case 'g': case 'g':
warnx("-g flag is deprecated and will be removed in FreeBSD 13.0");
dbg_port = atoi(optarg); dbg_port = atoi(optarg);
break; break;
case 'G': case 'G':