d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Save John Polstra's initial fix for profiling for reference. The

Browse Source 
multiplication in addupc() overflowed for addresses >= 256K, assuming
the usual profil(2) scale parameter of 0x8000.  addupc() will go away
soon.

Submitted by:	John Polstra <jdp@polstra.com>
This commit is contained in:
Bruce Evans 1996-06-25 19:25:25 +00:00
parent 7f37e6e23e
commit 93f4b1bf1b
3 changed files with 15 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
sys/amd64/amd64/cpu_switch.S
View File

@ -33,7 +33,7 @@
* OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
* SUCH DAMAGE.
*
* $Id: swtch.s,v 1.34 1996/04/25 06:20:08 phk Exp $
* $Id: swtch.s,v 1.35 1996/05/01 03:46:15 bde Exp $
*/
#include "apm.h"
@ -533,9 +533,10 @@ ENTRY(addupc)
subl PR_OFF(%edx),%eax /* pc -= up->pr_off */
jb L1 /* if (pc was < off) return */
shrl $1,%eax /* praddr = pc >> 1 */
imull PR_SCALE(%edx),%eax /* praddr *= up->pr_scale */
shrl $15,%eax /* praddr = praddr << 15 */
pushl %edx
mull PR_SCALE(%edx) /* praddr = pc * up->pr_scale */
shrdl $16,%edx,%eax /* praddr >>= 16 */
popl %edx
andl $-2,%eax /* praddr &= ~1 */
cmpl PR_SIZE(%edx),%eax /* if (praddr > up->pr_size) return */

9
sys/amd64/amd64/swtch.s
View File

@ -33,7 +33,7 @@
* OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
* SUCH DAMAGE.
*
* $Id: swtch.s,v 1.34 1996/04/25 06:20:08 phk Exp $
* $Id: swtch.s,v 1.35 1996/05/01 03:46:15 bde Exp $
*/
#include "apm.h"
@ -533,9 +533,10 @@ ENTRY(addupc)
subl PR_OFF(%edx),%eax /* pc -= up->pr_off */
jb L1 /* if (pc was < off) return */
shrl $1,%eax /* praddr = pc >> 1 */
imull PR_SCALE(%edx),%eax /* praddr *= up->pr_scale */
shrl $15,%eax /* praddr = praddr << 15 */
pushl %edx
mull PR_SCALE(%edx) /* praddr = pc * up->pr_scale */
shrdl $16,%edx,%eax /* praddr >>= 16 */
popl %edx
andl $-2,%eax /* praddr &= ~1 */
cmpl PR_SIZE(%edx),%eax /* if (praddr > up->pr_size) return */

9
sys/i386/i386/swtch.s
View File

@ -33,7 +33,7 @@
* OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
* SUCH DAMAGE.
*
* $Id: swtch.s,v 1.34 1996/04/25 06:20:08 phk Exp $
* $Id: swtch.s,v 1.35 1996/05/01 03:46:15 bde Exp $
*/
#include "apm.h"
@ -533,9 +533,10 @@ ENTRY(addupc)
subl PR_OFF(%edx),%eax /* pc -= up->pr_off */
jb L1 /* if (pc was < off) return */
shrl $1,%eax /* praddr = pc >> 1 */
imull PR_SCALE(%edx),%eax /* praddr *= up->pr_scale */
shrl $15,%eax /* praddr = praddr << 15 */
pushl %edx
mull PR_SCALE(%edx) /* praddr = pc * up->pr_scale */
shrdl $16,%edx,%eax /* praddr >>= 16 */
popl %edx
andl $-2,%eax /* praddr &= ~1 */
cmpl PR_SIZE(%edx),%eax /* if (praddr > up->pr_size) return */