From 946b2d00573bc4acd01da0cbb9fcb009b5539b46 Mon Sep 17 00:00:00 2001 From: Bill Fenner Date: Sat, 20 Apr 2002 17:00:56 +0000 Subject: [PATCH] Implement several of the c99 updates to scanf(3): - New length modifiers: hh, j, ll, t, z. Still to do: - %C, %S, %lc, %ls (wide character support) - %a/%A (exact hex representation of floating-point numbers) Removed old compatability equivalents: - %D for %ld, %O for %lo, %X for %lx, %E and %F for %le & %lf (these were buggy anyway, since they should have represented %Le & %Lf). - %[unknown uppercase char] for %ld, %[unknown lowercase char] for %d --- lib/libc/stdio/scanf.3 | 219 +++++++++++++++++++++++++-------------- lib/libc/stdio/vfscanf.c | 149 ++++++++++++++------------ 2 files changed, 224 insertions(+), 144 deletions(-) diff --git a/lib/libc/stdio/scanf.3 b/lib/libc/stdio/scanf.3 index 70ad9315df70..d1727fffc2b4 100644 --- a/lib/libc/stdio/scanf.3 +++ b/lib/libc/stdio/scanf.3 @@ -139,11 +139,20 @@ character introducing a conversion there may be a number of .Em flag characters, as follows: -.Bl -tag -width indent +.Bl -tag -width ".Cm l No (ell)" .It Cm * Suppresses assignment. The conversion that follows occurs as usual, but no pointer is used; the result of the conversion is simply discarded. +.It Cm hh +Indicates that the conversion will be one of +.Cm dioux +or +.Cm n +and the next pointer is a pointer to a +.Em char +(rather than +.Em int ) . .It Cm h Indicates that the conversion will be one of .Cm dioux @@ -153,8 +162,8 @@ and the next pointer is a pointer to a .Em short int (rather than .Em int ) . -.It Cm l -Indicates either that the conversion will be one of +.It Cm l No (ell) +Indicates that the conversion will be one of .Cm dioux or .Cm n @@ -162,29 +171,77 @@ and the next pointer is a pointer to a .Em long int (rather than .Em int ) , -or that the conversion will be one of -.Cm efg +that the conversion will be one of +.Cm aefg and the next pointer is a pointer to .Em double (rather than -.Em float ) . -.It Cm L -Indicates that the conversion will be -.Cm efg -and the next pointer is a pointer to -.Em long double . -(This type is not implemented; the -.Cm L -flag is currently ignored.) -.It Cm q -Indicates either that the conversion will be one of +.Em float ) , +or that the conversion will be one of +.Cm c +or +.Cm s +and the next pointer is a pointer to an array of +.Em wchar_t +(rather than +.Em char ) . +.It Cm ll No (ell ell) +Indicates that the conversion will be one of .Cm dioux or .Cm n and the next pointer is a pointer to a .Em long long int (rather than -.Em int ) , +.Em int ) . +.It Cm L +Indicates that the conversion will be one of +.Cm aef +or +.Cm g +and the next pointer is a pointer to +.Em long double . +(This type is not implemented; although the argument is +required to be a pointer to +.Em long double , +no additional precision is used in the conversion.) +.It Cm j +Indicates that the conversion will be one of +.Cm dioux +or +.Cm n +and the next pointer is a pointer to a +.Em intmax_t +(rather than +.Em int ) . +.It Cm t +Indicates that the conversion will be one of +.Cm dioux +or +.Cm n +and the next pointer is a pointer to a +.Em ptrdiff_t +(rather than +.Em int ) . +.It Cm z +Indicates that the conversion will be one of +.Cm dioux +or +.Cm n +and the next pointer is a pointer to a +.Em size_t +(rather than +.Em int ) . +.It Cm q +(deprecated.) +Indicates that the conversion will be one of +.Cm dioux +or +.Cm n +and the next pointer is a pointer to a +.Em long long int +(rather than +.Em int ) . .El .Pp In addition to these flags, @@ -212,10 +269,6 @@ No conversion is done, and assignment does not occur. Matches an optionally signed decimal integer; the next pointer must be a pointer to .Em int . -.It Cm D -Equivalent to -.Cm ld ; -this exists only for backwards compatibility. .It Cm i Matches an optionally signed integer; the next pointer must be a pointer to @@ -233,48 +286,37 @@ Only characters that correspond to the base are used. Matches an octal integer; the next pointer must be a pointer to .Em unsigned int . -.It Cm O -Equivalent to -.Cm lo ; -this exists for backwards compatibility. .It Cm u Matches an optionally signed decimal integer; the next pointer must be a pointer to .Em unsigned int . -.It Cm x +.It Cm x , X Matches an optionally signed hexadecimal integer; the next pointer must be a pointer to .Em unsigned int . -.It Cm X -Equivalent to -.Cm lx ; -this violates the -.St -isoC , -but is backwards compatible with previous -.Ux -systems. -.It Cm f +.It Cm e , E , f , F , g , G Matches an optionally signed floating-point number; the next pointer must be a pointer to .Em float . -.It Cm e -Equivalent to -.Cm f . -.It Cm g -Equivalent to -.Cm f . -.It Cm E -Equivalent to -.Cm lf ; -this violates the -.St -isoC , -but is backwards compatible with previous -.Ux -systems. -.It Cm F -Equivalent to -.Cm lf ; -this exists only for backwards compatibility. +.It Cm a , A +Matches a hexadecimal number represented in the style +.Sm off +.Oo \- Oc Li 0x Ar h Li \&. Ar hhh Cm p Oo \\*[Pm] Oc Ar d . +.Sm on +This is an exact conversion of the sign, exponent, mantissa internal +floating point representation; the +.Sm off +.Oo \- Oc Li 0x Ar h Li \&. Ar hhh +.Sm on +portion represents exactly the mantissa; only denormalized +mantissas have a zero value to the left of the hexadecimal +point. +The +.Cm p +is a literal character +.Ql p ; +the exponent is preceded by a positive or negative sign +and is represented in decimal. .It Cm s Matches a sequence of non-white-space characters; the next pointer must be a pointer to @@ -285,6 +327,9 @@ terminating character. The input string stops at white space or at the maximum field width, whichever occurs first. +.It Cm S +The same as +.Cm ls . .It Cm c Matches a sequence of .Em width @@ -298,6 +343,9 @@ and there must be enough room for all the characters is added). The usual skip of leading white space is suppressed. To skip white space first, use an explicit space in the format. +.It Cm C +The same as +.Cm lc . .It Cm \&[ Matches a nonempty sequence of characters from the specified set of accepted characters; @@ -365,29 +413,10 @@ character is defined in the program's locale (category .Dv LC_NUMERIC ) . .Pp For backwards compatibility, -other conversion characters (except -.Ql \e0 ) -are taken as if they were -.Ql %d -or, if uppercase, -.Ql %ld , -and a `conversion' of +a `conversion' of .Ql %\e0 causes an immediate return of .Dv EOF . -The -.Cm F -and -.Cm X -conversions will be changed in the future -to conform to the -.Tn ANSI -C standard, -after which they will act like -.Cm f -and -.Cm x -respectively. .Sh RETURN VALUES These functions @@ -421,15 +450,23 @@ The functions and .Fn sscanf conform to -.St -isoC . +.St -isoC-99 . .Sh BUGS -The current situation with -.Cm %F +Earlier implementations of +.Nm +treated +.Cm \&%D , \&%E , \&%F , \&%O and -.Cm %X -conversions is unfortunate. -.Pp -All of the backwards compatibility formats will be removed in the future. +.Cm \&%X +as their lowercase equivalents with an +.Cm l +modifier. In addition, +.Nm +treated an unknown conversion character as +.Cm \&%d +or +.Cm \&%D , +depending on its case. This functionality has been removed. .Pp Numerical strings are truncated to 512 characters; for example, .Cm %f @@ -439,3 +476,25 @@ are implicitly .Cm %512f and .Cm %512d . +.Pp +The +.Cm %n$ +modifiers for positional arguments are not implemented. +.Pp +The +.Cm l +modifier for +.Cm %c +and +.Cm %s +(and +.Cm %C +and +.Cm %S ) +to specify wide characters and strings is not implemented. +.Pp +The +.Cm \&%a +and +.Cm \&%A +floating-point formats are not implemented. diff --git a/lib/libc/stdio/vfscanf.c b/lib/libc/stdio/vfscanf.c index 484316219d78..a31d6ad05179 100644 --- a/lib/libc/stdio/vfscanf.c +++ b/lib/libc/stdio/vfscanf.c @@ -41,9 +41,11 @@ static char sccsid[] = "@(#)vfscanf.c 8.1 (Berkeley) 6/4/93"; __FBSDID("$FreeBSD$"); #include "namespace.h" +#include +#include #include #include -#include +#include #if __STDC__ #include #else @@ -71,10 +73,15 @@ __FBSDID("$FreeBSD$"); #define LONG 0x01 /* l: long or double */ #define LONGDBL 0x02 /* L: long double */ #define SHORT 0x04 /* h: short */ -#define SUPPRESS 0x08 /* suppress assignment */ -#define POINTER 0x10 /* weird %p pointer (`fake hex') */ -#define NOSKIP 0x20 /* do not skip blanks */ -#define QUAD 0x400 +#define SUPPRESS 0x08 /* *: suppress assignment */ +#define POINTER 0x10 /* p: void * (as hex) */ +#define NOSKIP 0x20 /* [ or c: do not skip blanks */ +#define LONGLONG 0x400 /* ll: long long (+ deprecated q: quad) */ +#define INTMAXT 0x800 /* j: intmax_t */ +#define PTRDIFFT 0x1000 /* t: ptrdiff_t */ +#define SIZET 0x2000 /* z: size_t */ +#define SHORTSHORT 0x4000 /* hh: char */ +#define UNSIGNED 0x8000 /* %[oupxX] conversions */ /* * The following are used in numeric conversions only: @@ -96,13 +103,10 @@ __FBSDID("$FreeBSD$"); #define CT_CHAR 0 /* %c conversion */ #define CT_CCL 1 /* %[...] conversion */ #define CT_STRING 2 /* %s conversion */ -#define CT_INT 3 /* integer, i.e., strtoq or strtouq */ -#define CT_FLOAT 4 /* floating, i.e., strtod */ +#define CT_INT 3 /* %[dioupxX] conversion */ +#define CT_FLOAT 4 /* %[efgEFG] conversion */ -#define u_char unsigned char -#define u_long unsigned long - -static u_char *__sccl(char *, u_char *); +static const u_char *__sccl(char *, const u_char *); /* * __vfscanf - MT-safe version @@ -122,9 +126,9 @@ __vfscanf(FILE *fp, char const *fmt0, va_list ap) * __svfscanf - non-MT-safe version of __vfscanf */ int -__svfscanf(FILE *fp, char const *fmt0, va_list ap) +__svfscanf(FILE *fp, const char *fmt0, va_list ap) { - u_char *fmt = (u_char *)fmt0; + const u_char *fmt = (const u_char *)fmt0; int c; /* character from format, or conversion */ size_t width; /* field width, or 0 */ char *p; /* points into all kinds of strings */ @@ -134,8 +138,7 @@ __svfscanf(FILE *fp, char const *fmt0, va_list ap) int nassigned; /* number of fields assigned */ int nconversions; /* number of conversions */ int nread; /* number of characters consumed from fp */ - int base; /* base argument to strtoq/strtouq */ - u_quad_t(*ccfn)(); /* conversion function (strtoq/strtouq) */ + int base; /* base argument to conversion function */ char ccltab[256]; /* character class table for %[...] */ char buf[BUF]; /* buffer for numeric conversions */ @@ -149,8 +152,6 @@ __svfscanf(FILE *fp, char const *fmt0, va_list ap) nassigned = 0; nconversions = 0; nread = 0; - base = 0; /* XXX just to keep gcc happy */ - ccfn = NULL; /* XXX just to keep gcc happy */ for (;;) { c = *fmt++; if (c == 0) @@ -183,17 +184,34 @@ again: c = *fmt++; case '*': flags |= SUPPRESS; goto again; + case 'j': + flags |= INTMAXT; + goto again; case 'l': - flags |= LONG; + if (flags & LONG) { + flags &= ~LONG; + flags |= LONGLONG; + } else + flags |= LONG; goto again; case 'q': - flags |= QUAD; + flags |= LONGLONG; /* not quite */ + goto again; + case 't': + flags |= PTRDIFFT; + goto again; + case 'z': + flags |= SIZET; goto again; case 'L': flags |= LONGDBL; goto again; case 'h': - flags |= SHORT; + if (flags & SHORT) { + flags &= ~SHORT; + flags |= SHORTSHORT; + } else + flags |= SHORT; goto again; case '0': case '1': case '2': case '3': case '4': @@ -203,61 +221,47 @@ again: c = *fmt++; /* * Conversions. - * Those marked `compat' are for 4.[123]BSD compatibility. - * - * (According to ANSI, E and X formats are supposed - * to the same as e and x. Sorry about that.) */ - case 'D': /* compat */ - flags |= LONG; - /* FALLTHROUGH */ case 'd': c = CT_INT; - ccfn = (u_quad_t (*)())strtoq; base = 10; break; case 'i': c = CT_INT; - ccfn = (u_quad_t (*)())strtoq; base = 0; break; - case 'O': /* compat */ - flags |= LONG; - /* FALLTHROUGH */ case 'o': c = CT_INT; - ccfn = strtouq; + flags |= UNSIGNED; base = 8; break; case 'u': c = CT_INT; - ccfn = strtouq; + flags |= UNSIGNED; base = 10; break; - case 'X': /* compat XXX */ - flags |= LONG; - /* FALLTHROUGH */ + case 'X': case 'x': flags |= PFXOK; /* enable 0x prefixing */ c = CT_INT; - ccfn = strtouq; + flags |= UNSIGNED; base = 16; break; #ifdef FLOATING_POINT - case 'E': /* compat XXX */ - case 'F': /* compat */ - flags |= LONG; - /* FALLTHROUGH */ + case 'E': case 'F': case 'G': case 'e': case 'f': case 'g': c = CT_FLOAT; break; #endif + case 'S': + flags |= LONG; + /* FALLTHROUGH */ case 's': c = CT_STRING; break; @@ -268,6 +272,9 @@ again: c = *fmt++; c = CT_CCL; break; + case 'C': + flags |= LONG; + /* FALLTHROUGH */ case 'c': flags |= NOSKIP; c = CT_CHAR; @@ -275,8 +282,8 @@ again: c = *fmt++; case 'p': /* pointer format is like hex */ flags |= POINTER | PFXOK; - c = CT_INT; - ccfn = strtouq; + c = CT_INT; /* assumes sizeof(uintmax_t) */ + flags |= UNSIGNED; /* >= sizeof(uintptr_t) */ base = 16; break; @@ -284,29 +291,32 @@ again: c = *fmt++; nconversions++; if (flags & SUPPRESS) /* ??? */ continue; - if (flags & SHORT) + if (flags & SHORTSHORT) + *va_arg(ap, char *) = nread; + else if (flags & SHORT) *va_arg(ap, short *) = nread; else if (flags & LONG) *va_arg(ap, long *) = nread; - else if (flags & QUAD) - *va_arg(ap, quad_t *) = nread; + else if (flags & LONGLONG) + *va_arg(ap, long long *) = nread; + else if (flags & INTMAXT) + *va_arg(ap, intmax_t *) = nread; + else if (flags & SIZET) + *va_arg(ap, size_t *) = nread; + else if (flags & PTRDIFFT) + *va_arg(ap, ptrdiff_t *) = nread; else *va_arg(ap, int *) = nread; continue; + default: + goto match_failure; + /* - * Disgusting backwards compatibility hacks. XXX + * Disgusting backwards compatibility hack. XXX */ case '\0': /* compat */ return (EOF); - - default: /* compat */ - if (isupper(c)) - flags |= LONG; - c = CT_INT; - ccfn = (u_quad_t (*)())strtoq; - base = 10; - break; } /* @@ -449,7 +459,7 @@ again: c = *fmt++; continue; case CT_INT: - /* scan an integer as if by strtoq/strtouq */ + /* scan an integer as if by the conversion function */ #ifdef hardway if (width == 0 || width > sizeof(buf) - 1) width = sizeof(buf) - 1; @@ -567,19 +577,30 @@ again: c = *fmt++; (void) __ungetc(c, fp); } if ((flags & SUPPRESS) == 0) { - u_quad_t res; + uintmax_t res; *p = 0; - res = (*ccfn)(buf, (char **)NULL, base); + if ((flags & UNSIGNED) == 0) + res = strtoimax(buf, (char **)NULL, base); + else + res = strtoumax(buf, (char **)NULL, base); if (flags & POINTER) *va_arg(ap, void **) = - (void *)(u_long)res; + (void *)(uintptr_t)res; + else if (flags & SHORTSHORT) + *va_arg(ap, char *) = res; else if (flags & SHORT) *va_arg(ap, short *) = res; else if (flags & LONG) *va_arg(ap, long *) = res; - else if (flags & QUAD) - *va_arg(ap, quad_t *) = res; + else if (flags & LONGLONG) + *va_arg(ap, long long *) = res; + else if (flags & INTMAXT) + *va_arg(ap, intmax_t *) = res; + else if (flags & PTRDIFFT) + *va_arg(ap, ptrdiff_t *) = res; + else if (flags & SIZET) + *va_arg(ap, size_t *) = res; else *va_arg(ap, int *) = res; nassigned++; @@ -698,10 +719,10 @@ again: c = *fmt++; * closing `]'. The table has a 1 wherever characters should be * considered part of the scanset. */ -static u_char * +static const u_char * __sccl(tab, fmt) char *tab; - u_char *fmt; + const u_char *fmt; { int c, n, v, i;