d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix a bug where TAILQ_FIRST(&V_ifnet) was accessed without holding the

Browse Source 
proper lock.

Reviewed by:	bz
MFC after:	1 week
This commit is contained in:
John Baldwin 2011-12-24 18:11:54 +00:00
parent 6512fa7aec
commit 94e8313349
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
sys/netinet6/icmp6.c
View File

@ -1851,7 +1851,7 @@ static int
ni6_store_addrs(struct icmp6_nodeinfo *ni6, struct icmp6_nodeinfo *nni6, ni6_store_addrs(struct icmp6_nodeinfo *ni6, struct icmp6_nodeinfo *nni6,
struct ifnet *ifp0, int resid) struct ifnet *ifp0, int resid)
{ {
struct ifnet *ifp = ifp0 ? ifp0 : TAILQ_FIRST(&V_ifnet); struct ifnet *ifp;
struct in6_ifaddr *ifa6; struct in6_ifaddr *ifa6;
struct ifaddr *ifa; struct ifaddr *ifa;
struct ifnet *ifp_dep = NULL; struct ifnet *ifp_dep = NULL;
@ -1864,6 +1864,7 @@ ni6_store_addrs(struct icmp6_nodeinfo *ni6, struct icmp6_nodeinfo *nni6,
return (0); /* needless to copy */ return (0); /* needless to copy */
IFNET_RLOCK_NOSLEEP(); IFNET_RLOCK_NOSLEEP();
ifp = ifp0 ? ifp0 : TAILQ_FIRST(&V_ifnet);
again: again:
for (; ifp; ifp = TAILQ_NEXT(ifp, if_list)) { for (; ifp; ifp = TAILQ_NEXT(ifp, if_list)) {