d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

trpt(8): Clean up build hack to detect ancient compiler

Browse Source 
Detect ancient GCC specifically, rather than using target architecture as a
crude heuristic.

Side note: compilers should really ignore -Wno- and -Wno-error= flags they
don't recognize.  Seems like modern compilers produce warnings instead of
errors.  Though, with -Werror they turn into errors.  Clang's error can be
disabled with -Wno-error=unknown-warning-option, but GCC doesn't seem to
have a named method to disable the specific warning.

Submitted by:	rpokala@ (earlier version)
Suggested by:	rpokala@
Reviewed by:	tinderbox
Sponsored by:	Dell EMC Isilon
This commit is contained in:
Conrad Meyer 2018-02-16 20:46:44 +00:00
parent 954b921d66
commit 9531d560cf
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
usr.sbin/trpt/Makefile
View File

@ -8,8 +8,7 @@ MAN= trpt.8
BINGRP= kmem
BINMODE= 2555
.if ${MACHINE_CPUARCH} != "aarch64" && ${MACHINE_CPUARCH} != "amd64" && \
${MACHINE_CPUARCH} != "i386" && ${MACHINE_CPUARCH} != "riscv"
.if ${COMPILER_TYPE} == "gcc" && ${COMPILER_VERSION} < 50000
WARNS?= 4
.endif
@ -19,8 +18,7 @@ CFLAGS+= -DINET6
.include <bsd.prog.mk>
.if ${MACHINE_CPUARCH} == "aarch64" || ${MACHINE_CPUARCH} == "amd64" || \
${MACHINE_CPUARCH} == "i386" || ${MACHINE_CPUARCH} == "riscv"
.if ${COMPILER_TYPE} != "gcc" || ${COMPILER_VERSION} >= 50000
# Several included system headers tickle this warning in ways that are
# difficult to work around in this program.
CFLAGS+= -Wno-missing-variable-declarations