d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add a reference and lock the target thread when setting its name.

Browse Source 
Submitted by:	davidxu (via libthr)
This commit is contained in:
Daniel Eischen 2007-04-23 03:36:14 +00:00
parent 6f91e7a3af
commit 96c57267f5
2 changed files with 52 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
lib/libkse/thread/thr_info.c
View File

@ -214,12 +214,31 @@ dump_thread(int fd, pthread_t pthread, int long_version)
void
_pthread_set_name_np(pthread_t thread, char *name)
{
/* Check if the caller has specified a valid thread: */
if (thread != NULL && thread->magic == THR_MAGIC) {
if (thread->name != NULL) {
/* Free space for previous name. */
free(thread->name);
}
thread->name = strdup(name);
struct pthread *curthread = _get_curthread();
char *new_name;
char *prev_name;
int ret;
new_name = strdup(name);
/* Add a reference to the target thread. */
if (_thr_ref_add(curthread, thread, 0) != 0) {
free(new_name);
ret = ESRCH;
}
else {
THR_THREAD_LOCK(curthread, thread);
prev_name = thread->name;
thread->name = new_name;
THR_THREAD_UNLOCK(curthread, thread);
_thr_ref_delete(curthread, thread);
if (prev_name != NULL) {
/* Free space for previous name. */
free(prev_name);
}
ret = 0;
}
#if 0
/* XXX - Should return error code. */
return (ret);
#endif
}

33
lib/libpthread/thread/thr_info.c
View File

@ -214,12 +214,31 @@ dump_thread(int fd, pthread_t pthread, int long_version)
void
_pthread_set_name_np(pthread_t thread, char *name)
{
/* Check if the caller has specified a valid thread: */
if (thread != NULL && thread->magic == THR_MAGIC) {
if (thread->name != NULL) {
/* Free space for previous name. */
free(thread->name);
}
thread->name = strdup(name);
struct pthread *curthread = _get_curthread();
char *new_name;
char *prev_name;
int ret;
new_name = strdup(name);
/* Add a reference to the target thread. */
if (_thr_ref_add(curthread, thread, 0) != 0) {
free(new_name);
ret = ESRCH;
}
else {
THR_THREAD_LOCK(curthread, thread);
prev_name = thread->name;
thread->name = new_name;
THR_THREAD_UNLOCK(curthread, thread);
_thr_ref_delete(curthread, thread);
if (prev_name != NULL) {
/* Free space for previous name. */
free(prev_name);
}
ret = 0;
}
#if 0
/* XXX - Should return error code. */
return (ret);
#endif
}