d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Avoid use after free.

Browse Source 
Reported by:	Clang static code analyzer
MFC after:	2 weeks
This commit is contained in:
Xin LI 2016-12-26 17:10:41 +00:00
parent a0a23564a3
commit 9a0ebab4d4
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
libexec/talkd/table.c
View File

@ -82,14 +82,15 @@ static TABLE_ENTRY *table = NIL;
CTL_MSG *
find_match(CTL_MSG *request)
{
TABLE_ENTRY *ptr;
TABLE_ENTRY *ptr, *next;
time_t current_time;
gettimeofday(&tp, NULL);
current_time = tp.tv_sec;
if (debug)
print_request("find_match", request);
for (ptr = table; ptr != NIL; ptr = ptr->next) {
for (ptr = table; ptr != NIL; ptr = next) {
next = ptr->next;
if ((ptr->time - current_time) > MAX_LIFE) {
/* the entry is too old */
if (debug)
@ -115,7 +116,7 @@ find_match(CTL_MSG *request)
CTL_MSG *
find_request(CTL_MSG *request)
{
TABLE_ENTRY *ptr;
TABLE_ENTRY *ptr, *next;
time_t current_time;
gettimeofday(&tp, NULL);
@ -126,7 +127,8 @@ find_request(CTL_MSG *request)
*/
if (debug)
print_request("find_request", request);
for (ptr = table; ptr != NIL; ptr = ptr->next) {
for (ptr = table; ptr != NIL; ptr = next) {
next = ptr->next;
if ((ptr->time - current_time) > MAX_LIFE) {
/* the entry is too old */
if (debug)