d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Do not attempt to free static memory.

Browse Source 
Reference ISC BIND issue:
``1278.   [bug]           free() of non-malloced memory in nslookup.''

Reported by:	phkmalloc, Mike Tancsa <mike@sentex.net>
This commit is contained in:
Jacques Vidrine 2002-05-22 14:24:44 +00:00
parent e0f783d4f8
commit 9aee5e4673
1 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
contrib/bind/bin/nslookup/getinfo.c
View File

@ -387,10 +387,8 @@ GetAnswer(nsAddrPtr, queryType, msg, msglen, iquery, hostPtr, isServer,
for (l = 0; l < k; l++)
if (!strcasecmp(hostPtr->aliases[l], host_aliases[i]))
break;
if (l < k) {
free(host_aliases[i]);
if (l < k)
continue;
}
hostPtr->aliases[k] = Calloc(1, host_aliases_len[i]);
memcpy(hostPtr->aliases[k], host_aliases[i],
host_aliases_len[i]);
@ -420,10 +418,8 @@ GetAnswer(nsAddrPtr, queryType, msg, msglen, iquery, hostPtr, isServer,
!memcmp(hostPtr->addrList[l]->addr, addr_list[i],
addr_len[i]))
break;
if (l < k) {
free(addr_list[i]);
if (l < k)
continue;
}
hostPtr->addrList[k] = (AddrInfo*)Calloc(1, sizeof(AddrInfo));
hostPtr->addrList[k]->addr = Calloc(1, addr_len[i]);
hostPtr->addrList[k]->addrType = addr_type[i];