d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

libexecinfo test: Don't strip installed test

Browse Source 
It turns out that a test of backtrace symbol resolution and formatting
requires symbols.  Another option mightt be building with -rdynamic instead,
but this works for now.

Re-enabled skipped CI test, as it should now pass.

PR:		241562
Submitted by:	lwhsu
Reported by:	lwhsu
X-MFC-With:	r354126, r354135, r354144
This commit is contained in:
cem 2019-10-29 18:24:36 +00:00
parent 4d54a39862
commit 9b17099b87
2 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
contrib/netbsd-tests/lib/libexecinfo/t_backtrace.c
View File

@ -151,9 +151,6 @@ ATF_TC_HEAD(backtrace_fmt_basic, tc)
ATF_TC_BODY(backtrace_fmt_basic, tc)
{
if (atf_tc_get_config_var_as_bool_wd(tc, "ci", false))
atf_tc_skip("https://bugs.freebsd.org/241562");
myfunc(12);
if (prevent_inline)

6
lib/libexecinfo/tests/Makefile
View File

@ -6,6 +6,12 @@ TESTSRC= ${SRCTOP}/contrib/netbsd-tests/lib/libexecinfo
.include <bsd.own.mk>
# Perhaps not surprisingly, the backtrace symbol test needs symbols. Leave
# them in:
STRIP=
# It could probably be made to work without symbols by checking pointer values
# instead, but part of the tested functionality is the symbol resolution logic,
# so that doesn't seem useful.
NETBSD_ATF_TESTS_C+= backtrace_test
LIBADD.backtrace_test+= execinfo