d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

cnclose() can potentially race against itself. To avoid vn_close() races,

Browse Source 
NULL-out cnd_vp before calling the latter, as it may block.

Submitted by: dillon
This commit is contained in:
jlemon 2001-10-25 04:51:37 +00:00
parent fe5999a4cb
commit 9b2f683d9c
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
sys/kern/tty_cons.c
View File

@ -381,12 +381,13 @@ static int
cnclose(dev_t dev, int flag, int mode, struct thread *td)
{
struct cn_device *cnd;
struct vnode *vp;
STAILQ_FOREACH(cnd, &cn_devlist, cnd_next) {
if (cnd->cnd_vp == NULL)
if ((vp = cnd->cnd_vp) == NULL)
continue;
vn_close(cnd->cnd_vp, openflag, td->td_proc->p_ucred, td);
cnd->cnd_vp = NULL;
vn_close(vp, openflag, td->td_proc->p_ucred, td);
}
cn_is_open = 0;
return (0);