d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

kmod.mk: Don't split out debug symbols if requested

Browse Source 
Ports bsd.kmod.mk explicitly sets MK_KERNEL_SYMBOLS=no to prevent auto-
splitting of debuginfo from kernel modules.  If that knob is set, don't
split out a .ko.debug and .ko from .ko.full; just generate a .ko with
debuginfo and leave it be.

Otherwise, with DEBUG_FLAGS set and MK_KERNEL_SYMBOLS=no, we would helpfully
strip out the debuginfo from the .ko.full and then not install it.  That is
not the desired result a WITH_DEBUG port kmod build.

Reviewed by:	emaste, jhb
Differential Revision:	https://reviews.freebsd.org/D24835
This commit is contained in:
Conrad Meyer 2020-06-23 18:25:31 +00:00
parent 4287cc440c
commit 9b6edf364e
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
sys/conf/kmod.mk
View File

@ -215,7 +215,7 @@ OBJS+= ${SRCS:N*.h:R:S/$/.o/g}
PROG= ${KMOD}.ko
.endif
.if !defined(DEBUG_FLAGS)
.if !defined(DEBUG_FLAGS) || ${MK_KERNEL_SYMBOLS} == "no"
FULLPROG= ${PROG}
.else
FULLPROG= ${PROG}.full
@ -319,7 +319,7 @@ ${_ILINKS}:
CLEANFILES+= ${PROG} ${KMOD}.kld ${OBJS}
.if defined(DEBUG_FLAGS)
.if defined(DEBUG_FLAGS) && ${MK_KERNEL_SYMBOLS} != "no"
CLEANFILES+= ${FULLPROG} ${PROG}.debug
.endif