sfxge: cleanup: report error on failure path in efx_vpd_hunk_verify
If the VPD is corrupt and contains an 'RV' keyword before the END tag, then this function could return without setting the return code to report the error. Found by prefast. Submitted by: Andy Moreton <amoreton at solarflare.com> Sponsored by: Solarflare Communications, Inc. MFC after: 2 days
This commit is contained in:
parent
14c3e490cd
commit
9dbc22c5aa
@ -545,8 +545,10 @@ efx_vpd_hunk_verify(
|
||||
|
||||
for (pos = 0; pos != taglen; pos += 3 + keylen) {
|
||||
/* RV keyword must be the last in the block */
|
||||
if (cksummed)
|
||||
if (cksummed) {
|
||||
rc = EFAULT;
|
||||
goto fail2;
|
||||
}
|
||||
|
||||
if ((rc = efx_vpd_next_keyword(data + offset,
|
||||
taglen, pos, &keyword, &keylen)) != 0)
|
||||
|
Loading…
Reference in New Issue
Block a user