From 9df24552a085698e7f10f5c16d79829ee20fa15f Mon Sep 17 00:00:00 2001 From: "Andrey A. Chernov" Date: Thu, 24 Jan 2002 22:19:21 +0000 Subject: [PATCH] Zeroing memset() in opiechallenge() really is not needed because it is the very first thing immediately following opielookup() does being entered, i.e. look at this: int opielookup FUNCTION((opie, principal), struct opie *opie AND char *principal ) { int i; memset(opie, 0, sizeof(struct opie)); ... --- contrib/opie/libopie/challenge.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/contrib/opie/libopie/challenge.c b/contrib/opie/libopie/challenge.c index 0f3fec55cf22..b93171492b8d 100644 --- a/contrib/opie/libopie/challenge.c +++ b/contrib/opie/libopie/challenge.c @@ -20,6 +20,9 @@ License Agreement applies to this software. syslog. Add sha plumbing. Modified by cmetz for OPIE 2.2. Use FUNCTION declaration et al. Created at NRL for OPIE 2.2 from opiesubr2.c + +$FreeBSD$ + */ #include "opie_cfg.h" #include @@ -52,8 +55,6 @@ int opiechallenge FUNCTION((mp, name, ss), struct opie *mp AND char *name AND ch { int rval = -1; - memset(mp, 0, sizeof(*mp)); - rval = opielookup(mp, name); #if DEBUG if (rval) syslog(LOG_DEBUG, "opiechallenge: opielookup(mp, name=%s) returned %d", name, rval);