d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Make toggling TSO, VLAN hardware checksum offloading work. Also fix

Browse Source 
TX/RX checksum handler to set/clear relavant assist bits which was
used to cause unexpected results.
With this change, bce(4) can be bridged with other interfaces that
lack TSO, VLAN checksum offloading.

Reviewed by:	davidch
This commit is contained in:
yongari 2010-02-26 20:39:07 +00:00
parent c08d71acc7
commit a4df49e099
1 changed files with 16 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
sys/dev/bce/if_bce.c
View File

@ -7102,33 +7102,35 @@ bce_ioctl(struct ifnet *ifp, u_long command, caddr_t data)
mask = ifr->ifr_reqcap ^ ifp->if_capenable;
DBPRINT(sc, BCE_INFO_MISC, "Received SIOCSIFCAP = 0x%08X\n", (u32) mask);
/* Toggle the TX checksum capabilites enable flag. */
if (mask & IFCAP_TXCSUM) {
/* Toggle the TX checksum capabilities enable flag. */
if (mask & IFCAP_TXCSUM &&
ifp->if_capabilities & IFCAP_TXCSUM) {
ifp->if_capenable ^= IFCAP_TXCSUM;
if (IFCAP_TXCSUM & ifp->if_capenable)
ifp->if_hwassist = BCE_IF_HWASSIST;
ifp->if_hwassist |= BCE_IF_HWASSIST;
else
ifp->if_hwassist = 0;
ifp->if_hwassist &= ~BCE_IF_HWASSIST;
}
/* Toggle the RX checksum capabilities enable flag. */
if (mask & IFCAP_RXCSUM) {
if (mask & IFCAP_RXCSUM &&
ifp->if_capabilities & IFCAP_RXCSUM)
ifp->if_capenable ^= IFCAP_RXCSUM;
if (IFCAP_RXCSUM & ifp->if_capenable)
ifp->if_hwassist = BCE_IF_HWASSIST;
else
ifp->if_hwassist = 0;
}
/* Toggle the TSO capabilities enable flag. */
if (bce_tso_enable && (mask & IFCAP_TSO4)) {
if (bce_tso_enable && (mask & IFCAP_TSO4) &&
ifp->if_capabilities & IFCAP_TSO4) {
ifp->if_capenable ^= IFCAP_TSO4;
if (IFCAP_RXCSUM & ifp->if_capenable)
ifp->if_hwassist = BCE_IF_HWASSIST;
if (IFCAP_TSO4 & ifp->if_capenable)
ifp->if_hwassist |= CSUM_TSO;
else
ifp->if_hwassist = 0;
ifp->if_hwassist &= ~CSUM_TSO;
}
if (mask & IFCAP_VLAN_HWCSUM &&
ifp->if_capabilities & IFCAP_VLAN_HWCSUM)
ifp->if_capenable ^= IFCAP_VLAN_HWCSUM;
/*
* Don't actually disable VLAN tag stripping as
* management firmware (ASF/IPMI/UMP) requires the