d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Lock object while we iterate through it's backing objects.

Browse Source 
Discussed with:	alc
This commit is contained in:
Christian S.J. Peron 2005-10-09 02:37:27 +00:00
parent cd604283af
commit a5b7fde722
1 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
sys/security/mac/mac_process.c
View File

@ -327,7 +327,7 @@ mac_cred_mmapped_drop_perms_recurse(struct thread *td, struct ucred *cred,
struct vm_map_entry *vme; struct vm_map_entry *vme;
int vfslocked, result; int vfslocked, result;
vm_prot_t revokeperms; vm_prot_t revokeperms;
vm_object_t object; vm_object_t backing_object, object;
vm_ooffset_t offset; vm_ooffset_t offset;
struct vnode *vp; struct vnode *vp;
@ -354,13 +354,14 @@ mac_cred_mmapped_drop_perms_recurse(struct thread *td, struct ucred *cred,
object = vme->object.vm_object; object = vme->object.vm_object;
if (object == NULL) if (object == NULL)
continue; continue;
/* XXXCSJP We need to lock the object before walking VM_OBJECT_LOCK(object);
* the backing object list. while ((backing_object = object->backing_object) != NULL) {
*/ VM_OBJECT_LOCK(backing_object);
while (object->backing_object != NULL) {
offset += object->backing_object_offset; offset += object->backing_object_offset;
object = object->backing_object; VM_OBJECT_UNLOCK(object);
object = backing_object;
} }
VM_OBJECT_UNLOCK(object);
/* /*
* At the moment, vm_maps and objects aren't considered * At the moment, vm_maps and objects aren't considered
* by the MAC system, so only things with backing by a * by the MAC system, so only things with backing by a