Prevent a non-exploitable remote buffer overflow.
Reported by: twitch <twitch@vicar.org> Submitted by: Guido van Rooij <guido@gvr.org> Reviewed by: security-officer
This commit is contained in:
parent
9369c9fb75
commit
a8cc952fab
@ -1791,10 +1791,10 @@ validate(sin, hname)
|
||||
/* traditional behaviour, allow everything */
|
||||
return 1;
|
||||
|
||||
strncpy(name, hname, sizeof name);
|
||||
strlcpy(name, hname, sizeof name);
|
||||
if (strchr(name, '.') == NULL) {
|
||||
strncat(name, ".", sizeof name - strlen(name) - 1);
|
||||
strncat(name, LocalDomain, sizeof name - strlen(name) - 1);
|
||||
strlcat(name, ".", sizeof name);
|
||||
strlcat(name, LocalDomain, sizeof name);
|
||||
}
|
||||
dprintf("validate: dgram from IP %s, port %d, name %s;\n",
|
||||
addr2ascii(AF_INET, &sin->sin_addr, sizeof(struct in_addr), 0),
|
||||
|
Loading…
x
Reference in New Issue
Block a user