d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Grrrr. Remember to bzero() the mediainfo structures after we allocate

Browse Source 
them. If we leave garbage in them, the dc_apply_fixup() routine may
try to follow bogus pointers when applying the reset fixup.

Noticed by: Andrew Gallatin
This commit is contained in:
wpaul 2000-11-03 00:03:03 +00:00
parent e3e49a5355
commit a963a930c8
2 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
sys/dev/dc/if_dc.c
View File

@ -1635,6 +1635,7 @@ static void dc_decode_leaf_sia(sc, l)
struct dc_mediainfo *m;
m = malloc(sizeof(struct dc_mediainfo), M_DEVBUF, M_NOWAIT);
bzero(m, sizeof(struct dc_mediainfo));
if (l->dc_sia_code == DC_SIA_CODE_10BT)
m->dc_media = IFM_10_T;
@ -1665,6 +1666,7 @@ static void dc_decode_leaf_sym(sc, l)
struct dc_mediainfo *m;
m = malloc(sizeof(struct dc_mediainfo), M_DEVBUF, M_NOWAIT);
bzero(m, sizeof(struct dc_mediainfo));
if (l->dc_sym_code == DC_SYM_CODE_100BT)
m->dc_media = IFM_100_TX;
@ -1690,6 +1692,7 @@ static void dc_decode_leaf_mii(sc, l)
struct dc_mediainfo *m;
m = malloc(sizeof(struct dc_mediainfo), M_DEVBUF, M_NOWAIT);
bzero(m, sizeof(struct dc_mediainfo));
/* We abuse IFM_AUTO to represent MII. */
m->dc_media = IFM_AUTO;
m->dc_gp_len = l->dc_gpr_len;

3
sys/pci/if_dc.c
View File

@ -1635,6 +1635,7 @@ static void dc_decode_leaf_sia(sc, l)
struct dc_mediainfo *m;
m = malloc(sizeof(struct dc_mediainfo), M_DEVBUF, M_NOWAIT);
bzero(m, sizeof(struct dc_mediainfo));
if (l->dc_sia_code == DC_SIA_CODE_10BT)
m->dc_media = IFM_10_T;
@ -1665,6 +1666,7 @@ static void dc_decode_leaf_sym(sc, l)
struct dc_mediainfo *m;
m = malloc(sizeof(struct dc_mediainfo), M_DEVBUF, M_NOWAIT);
bzero(m, sizeof(struct dc_mediainfo));
if (l->dc_sym_code == DC_SYM_CODE_100BT)
m->dc_media = IFM_100_TX;
@ -1690,6 +1692,7 @@ static void dc_decode_leaf_mii(sc, l)
struct dc_mediainfo *m;
m = malloc(sizeof(struct dc_mediainfo), M_DEVBUF, M_NOWAIT);
bzero(m, sizeof(struct dc_mediainfo));
/* We abuse IFM_AUTO to represent MII. */
m->dc_media = IFM_AUTO;
m->dc_gp_len = l->dc_gpr_len;