d/freebsd-skq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

bridge tests: Test for #216510

Browse Source 
We used to have an issue with recursive locking with
net.link.bridge.inherit_mac. This causes us to send an ARP request while
we hold the BRIDGE_LOCK, which used to cause us to acquire the
BRIDGE_LOCK again. We can't re-acquire it, so this caused a panic.

Now that we no longer need to acquire the BRIDGE_LOCK for
bridge_transmit() this should no longer panic. Test this.

PR:	216510
Reviewed by:	emaste, philip
MFC after:	2 months
Sponsored by:	The FreeBSD Foundation
Differential Revision:	https://reviews.freebsd.org/D24251
This commit is contained in:
kp 2020-04-26 16:27:03 +00:00
parent 4b1249e2de
commit aa14143cf0
1 changed files with 28 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
tests/sys/net/if_bridge_test.sh
View File

@ -309,12 +309,40 @@ mac_conflict_cleanup()
vnet_cleanup
}
atf_test_case "inherit_mac" "cleanup"
inherit_mac_head()
{
atf_set descr 'Bridge inherit_mac test, #216510'
atf_set require.user root
}
inherit_mac_body()
{
vnet_init
bridge=$(vnet_mkbridge)
epair=$(vnet_mkepair)
vnet_mkjail one ${bridge} ${epair}a
jexec one sysctl net.link.bridge.inherit_mac=1
# Attempt to provoke the panic described in #216510
jexec one ifconfig ${bridge} 192.0.0.1/24 up
jexec one ifconfig ${bridge} addm ${epair}a
}
inherit_mac_cleanup()
{
vnet_cleanup
}
atf_init_test_cases()
{
atf_add_test_case "bridge_transmit_ipv4_unicast"
atf_add_test_case "stp"
atf_add_test_case "static"
atf_add_test_case "span"
atf_add_test_case "inherit_mac"
atf_add_test_case "delete_with_members"
atf_add_test_case "mac_conflict"
}